chrome/browser/extensions/api/bookmark_manager_private/bookmark_manager_private_apitest.cc - Issue 2777063003: Stop passing raw pointers to base::Value API in c/b/chromeos and c/b/extensions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/api/bookmark_manager_private/bookmark_manager_private_apitest.cc

Issue 2777063003: Stop passing raw pointers to base::Value API in c/b/chromeos and c/b/extensions (Closed)

Patch Set: Fix SupervisedUserWhitelistInstaller Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/extensions/api/autotest_private/autotest_private_api.cc ('K') | « chrome/browser/extensions/api/autotest_private/autotest_private_api.cc ('k') | chrome/browser/extensions/api/bookmarks/bookmark_api_helpers.cc » ('j') | chrome/browser/extensions/api/bookmarks/bookmark_api_helpers.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/api/bookmark_manager_private/bookmark_manager_private_apitest.cc

diff --git a/chrome/browser/extensions/api/bookmark_manager_private/bookmark_manager_private_apitest.cc b/chrome/browser/extensions/api/bookmark_manager_private/bookmark_manager_private_apitest.cc

index c64ba831db188acf2d4c00017ad7680f16642f10..b0f1c361663b238b87d4d23aab3998fba57ec03d 100644

--- a/chrome/browser/extensions/api/bookmark_manager_private/bookmark_manager_private_apitest.cc

+++ b/chrome/browser/extensions/api/bookmark_manager_private/bookmark_manager_private_apitest.cc

@@ -47,7 +47,7 @@ IN_PROC_BROWSER_TEST_F(ExtensionApiTest, MAYBE_BookmarkManager) {

list.Append(std::move(node));

node.reset(new base::DictionaryValue());

node->SetString("name", "Managed Folder");

- node->Set("children", new base::ListValue());

+ node->Set("children", base::MakeUnique<base::ListValue>());

list.Append(std::move(node));

profile->GetPrefs()->Set(bookmarks::prefs::kManagedBookmarks, list);

ASSERT_EQ(2, managed->managed_node()->child_count());