chrome/browser/content_settings/content_settings_pref_provider_unittest.cc - Issue 2777063003: Stop passing raw pointers to base::Value API in c/b/chromeos and c/b/extensions

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/content_settings/content_settings_pref_provider_unittest.cc

Issue 2777063003: Stop passing raw pointers to base::Value API in c/b/chromeos and c/b/extensions (Closed)

Patch Set: Fix SupervisedUserWhitelistInstaller Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/component_updater/supervised_user_whitelist_installer_unittest.cc ('K') | « chrome/browser/component_updater/supervised_user_whitelist_installer_unittest.cc ('k') | chrome/browser/content_settings/host_content_settings_map_unittest.cc » ('j') | chrome/browser/devtools/devtools_targets_ui.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/content_settings/content_settings_pref_provider_unittest.cc

diff --git a/chrome/browser/content_settings/content_settings_pref_provider_unittest.cc b/chrome/browser/content_settings/content_settings_pref_provider_unittest.cc

index 35aba5250ea6151541522add1e1e733eefba5c3a..a59763fa7bc83107b88ab7ddd24bd217f7ed07a7 100644

--- a/chrome/browser/content_settings/content_settings_pref_provider_unittest.cc

+++ b/chrome/browser/content_settings/content_settings_pref_provider_unittest.cc

@@ -449,8 +449,8 @@ TEST_F(PrefProviderTest, Deadlock) {

{

DictionaryPrefUpdate update(&prefs, info->pref_name());

base::DictionaryValue* mutable_settings = update.Get();

- mutable_settings->SetWithoutPathExpansion("www.example.com,*",

- new base::DictionaryValue());

+ mutable_settings->SetWithoutPathExpansion(

+ "www.example.com,*", base::MakeUnique<base::DictionaryValue>());

}

EXPECT_TRUE(observer.notification_received());