Stop passing raw pointers to base::Value API in c/b/chromeos and c/b/extensions

chrome/browser/extensions/install_signer.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/install_signer.h"
 
 #include <stddef.h>
 #include <stdint.h>
 #include <utility>
 
 #include "base/base64.h"
 #include "base/bind.h"
 #include "base/command_line.h"
 #include "base/json/json_reader.h"
 #include "base/json/json_writer.h"
 #include "base/lazy_instance.h"
 #include "base/macros.h"
+#include "base/memory/ptr_util.h"
 #include "base/message_loop/message_loop.h"
 #include "base/metrics/histogram_macros.h"
 #include "base/process/process_info.h"
 #include "base/stl_util.h"
 #include "base/strings/string_number_conversions.h"
 #include "base/strings/string_split.h"
 #include "base/strings/string_util.h"
 #include "base/time/time.h"
 #include "base/values.h"
 #include "build/build_config.h"
@@ skipping 90 matching lines @@
     }
   }
   return true;
 }
 
 // Sets the value of |key| in |dictionary| to be a list with the contents of
 // |ids|.
 void SetExtensionIdSet(base::DictionaryValue* dictionary,
                        const char* key,
                        const ExtensionIdSet& ids) {
-  base::ListValue* id_list = new base::ListValue();
+  auto id_list = base::MakeUnique<base::ListValue>();
   for (ExtensionIdSet::const_iterator i = ids.begin(); i != ids.end(); ++i)
     id_list->AppendString(*i);
-  dictionary->Set(key, id_list);
+  dictionary->Set(key, std::move(id_list));
 }
 
 // Tries to fetch a list of strings from |dictionay| for |key|, and inserts
 // them into |ids|. The return value indicates success/failure. Note: on
 // failure, |ids| might contain partial results, for instance if some of the
 // members of the list were not strings.
 bool GetExtensionIdSet(const base::DictionaryValue& dictionary,
                        const char* key,
                        ExtensionIdSet* ids) {
   const base::ListValue* id_list = NULL;
@@ skipping 241 matching lines @@
   //   "hash": "<base64-encoded hash value here>",
   //   "ids": [ "<id1>", "id2" ]
   // }
   base::DictionaryValue dictionary;
   dictionary.SetInteger(kProtocolVersionKey, 1);
   dictionary.SetString(kHashKey, hash_base64);
   std::unique_ptr<base::ListValue> id_list(new base::ListValue);
   for (ExtensionIdSet::const_iterator i = ids_.begin(); i != ids_.end(); ++i) {
     id_list->AppendString(*i);
   }
-  dictionary.Set(kIdsKey, id_list.release());
+  dictionary.Set(kIdsKey, std::move(id_list));
   std::string json;
   base::JSONWriter::Write(dictionary, &json);
   if (json.empty()) {
     ReportErrorViaCallback();
     return;
   }
   url_fetcher_->SetUploadData("application/json", json);
   LogRequestStartHistograms();
   request_start_time_ = base::Time::Now();
   VLOG(1) << "Sending request: " << json;
@@ skipping 101 matching lines @@
     if (!verified)
       result.reset();
   }
 
   if (!callback_.is_null())
     callback_.Run(std::move(result));
 }
 
 
 }  // namespace extensions