Stop passing raw pointers to base::Value API in c/b/chromeos and c/b/extensions

chrome/browser/extensions/extension_gcm_app_handler_unittest.cc

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/extension_gcm_app_handler.h"
 
 #include <memory>

[jdoerrie, 2017/04/06 14:25:51]

#include <utility>

[vabr (Chromium), 2017/04/07 20:40:40]

Done.

 #include <vector>
 
 #include "base/bind.h"
 #include "base/bind_helpers.h"
 #include "base/command_line.h"
 #include "base/files/file_path.h"
 #include "base/files/file_util.h"
 #include "base/files/scoped_temp_dir.h"
 #include "base/location.h"
 #include "base/logging.h"
@@ skipping 262 matching lines @@
 
     waiter_.PumpUILoop();
     gcm_app_handler_->Shutdown();
   }
 
   // Returns a barebones test extension.
   scoped_refptr<Extension> CreateExtension() {
     base::DictionaryValue manifest;
     manifest.SetString(manifest_keys::kVersion, "1.0.0.0");
     manifest.SetString(manifest_keys::kName, kTestExtensionName);
-    base::ListValue* permission_list = new base::ListValue;
+    auto permission_list = base::MakeUnique<base::ListValue>();
     permission_list->AppendString("gcm");
-    manifest.Set(manifest_keys::kPermissions, permission_list);
+    manifest.Set(manifest_keys::kPermissions, std::move(permission_list));
 
     std::string error;
     scoped_refptr<Extension> extension = Extension::Create(
         temp_dir_.GetPath(), Manifest::UNPACKED, manifest, Extension::NO_FLAGS,
         "ldnnhddmnhbkjipkidpdiheffobcpfmf", &error);
     EXPECT_TRUE(extension.get()) << error;
     EXPECT_TRUE(
         extension->permissions_data()->HasAPIPermission(APIPermission::kGcm));
 
     return extension;
@@ skipping 180 matching lines @@
 
   // App handler is removed when the extension is updated to the version that
   // has GCM permission removed.
   UpdateExtension(extension.get(), "good2.crx");
   waiter()->PumpUILoop();
   EXPECT_TRUE(gcm_app_handler()->app_handler_count_drop_to_zero());
   EXPECT_FALSE(HasAppHandlers(extension->id()));
 }
 
 }  // namespace extensions