Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(259)

Issue 277703002: Remove synchronous compositeAndReadback() from WebLayerTreeView impls. (Closed)

Created:
6 years, 7 months ago by danakj
Modified:
6 years, 7 months ago
Reviewers:
piman
CC:
chromium-reviews, piman+watch_chromium.org, jam, darin-cc_chromium.org, abarth-chromium, enne (OOO)
Visibility:
Public.

Description

Remove synchronous compositeAndReadback() from WebLayerTreeView impls. Removes it from the RenderWidgetCompositor and WebLayerTreeViewImplForTesting classes. Depends on: https://codereview.chromium.org/276753002/ R=piman BUG=251936 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=269842

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -14 lines) Patch
M content/renderer/gpu/render_widget_compositor.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/gpu/render_widget_compositor.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M content/test/web_layer_tree_view_impl_for_testing.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/test/web_layer_tree_view_impl_for_testing.cc View 1 chunk +0 lines, -6 lines 0 comments Download

Messages

Total messages: 11 (0 generated)
danakj
6 years, 7 months ago (2014-05-08 22:02:21 UTC) #1
piman
lgtm
6 years, 7 months ago (2014-05-08 22:12:28 UTC) #2
danakj
The CQ bit was checked by danakj@chromium.org
6 years, 7 months ago (2014-05-12 14:28:46 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/danakj@chromium.org/277703002/1
6 years, 7 months ago (2014-05-12 14:29:04 UTC) #4
commit-bot: I haz the power
FYI, CQ is re-trying this CL (attempt #1). Please consider checking whether the failures are ...
6 years, 7 months ago (2014-05-12 16:23:53 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 7 months ago (2014-05-12 17:44:44 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: android_dbg_triggered_tests on tryserver.chromium (http://build.chromium.org/p/tryserver.chromium/builders/android_dbg_triggered_tests/builds/153020)
6 years, 7 months ago (2014-05-12 17:44:44 UTC) #7
danakj
Oh good this test is also failing on https://codereview.chromium.org/274453002/, it's not magically somehow related to ...
6 years, 7 months ago (2014-05-12 18:10:41 UTC) #8
danakj
The CQ bit was checked by danakj@chromium.org
6 years, 7 months ago (2014-05-12 18:10:51 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/danakj@chromium.org/277703002/1
6 years, 7 months ago (2014-05-12 18:11:15 UTC) #10
commit-bot: I haz the power
6 years, 7 months ago (2014-05-12 19:25:55 UTC) #11
Message was sent while issue was closed.
Change committed as 269842

Powered by Google App Engine
This is Rietveld 408576698