MD Settings: Prevent erroneous scroll when navigating subpage->subpage.

chrome/browser/resources/settings/settings_page/main_page_behavior.js

Index: chrome/browser/resources/settings/settings_page/main_page_behavior.js
diff --git a/chrome/browser/resources/settings/settings_page/main_page_behavior.js b/chrome/browser/resources/settings/settings_page/main_page_behavior.js
index 600499e704e72bcd590b9649e15e087b4fd2290b..96137fda6f2de4b07fe2ce0909d24d9429c93586 100644
--- a/chrome/browser/resources/settings/settings_page/main_page_behavior.js
+++ b/chrome/browser/resources/settings/settings_page/main_page_behavior.js
@@ -287,6 +287,7 @@ var MainPageBehaviorImpl = {
       // Wait for the other sections to show up so we can scroll properly.
       setTimeout(function() {
         var newSection = settings.getCurrentRoute().section &&
+            !settings.getCurrentRoute().isSubpage() &&

[michaelpg, 2017/03/29 01:11:21]

I think this would be clearer as part of the "if" below, i.e. in the same check
as !wasPopState. |newSection| is just storing the current section which is
"correct" either way.

[tommycli, 2017/03/29 16:27:21]

Done.

             this.getSection(settings.getCurrentRoute().section);
 
         // Scroll to the new section or the original position.