MD Settings: Prevent erroneous scroll when navigating subpage->subpage.

chrome/browser/resources/settings/settings_page/main_page_behavior.js

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * Responds to route changes by expanding, collapsing, or scrolling to sections
  * on the page. Expanded sections take up the full height of the container. At
  * most one section should be expanded at any given time.
  * @polymerBehavior MainPageBehavior
  */
@@ skipping 269 matching lines @@
       // Finish by restoring the section into the page.
       section.setFrozen(false);
       return Promise.resolve();
     }
 
     // Play the actual collapse animation.
     return new Promise(function(resolve, reject) {
       // Wait for the other sections to show up so we can scroll properly.
       setTimeout(function() {
         var newSection = settings.getCurrentRoute().section &&
+            !settings.getCurrentRoute().isSubpage() &&

[michaelpg, 2017/03/29 01:11:21]

I think this would be clearer as part of the "if" below, i.e. in the same check
as !wasPopState. |newSection| is just storing the current section which is
"correct" either way.

[tommycli, 2017/03/29 16:27:21]

Done.

             this.getSection(settings.getCurrentRoute().section);
 
         // Scroll to the new section or the original position.
         if (newSection && !settings.lastRouteChangeWasPopstate())
           newSection.scrollIntoView();
         else
           this.scroller.scrollTop = this.origScrollTop_;
 
         this.currentAnimation_ = section.animateCollapse(
             /** @type {!HTMLElement} */(this.scroller));
@@ skipping 38 matching lines @@
     return /** @type {?SettingsSectionElement} */(
         this.$$('settings-section[section="' + section + '"]'));
   },
 };
 
 /** @polymerBehavior */
 var MainPageBehavior = [
   settings.RouteObserverBehavior,
   MainPageBehaviorImpl,
 ];