Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(711)

Unified Diff: ui/compositor/compositor.cc

Issue 2776973004: Remove CompositorObserver::OnCompositingEnded() (Closed)
Patch Set: Move ++committed_frame_number_; to DidSubmitCompositorFrame() Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/browser/renderer_host/delegated_frame_host.cc ('k') | ui/compositor/compositor_observer.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/compositor/compositor.cc
diff --git a/ui/compositor/compositor.cc b/ui/compositor/compositor.cc
index 81a934550879bc91ea2e3d17bc273a65b206dbe4..cdb78a55720cac8def13b32e29115b133df6b465 100644
--- a/ui/compositor/compositor.cc
+++ b/ui/compositor/compositor.cc
@@ -529,14 +529,11 @@ void Compositor::DidCommit() {
observer.OnCompositingDidCommit(this);
}
-void Compositor::DidReceiveCompositorFrameAck() {
- ++committed_frame_number_;
- for (auto& observer : observer_list_)
- observer.OnCompositingEnded(this);
-}
+void Compositor::DidReceiveCompositorFrameAck() {}
void Compositor::DidSubmitCompositorFrame() {
base::TimeTicks start_time = base::TimeTicks::Now();
+ ++committed_frame_number_;
danakj 2017/03/28 16:04:54 This would change the result of Layer::GetFrameNum
Fady Samuel 2017/03/28 17:35:05 As I said offline, we can undo this change and lan
Alex Z. 2017/03/28 18:08:27 This change has been reverted in the latest patch.
for (auto& observer : observer_list_)
observer.OnCompositingStarted(this, start_time);
}
« no previous file with comments | « content/browser/renderer_host/delegated_frame_host.cc ('k') | ui/compositor/compositor_observer.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698