Remove CompositorObserver::OnCompositingEnded()

ui/compositor/layer_unittest.cc

Index: ui/compositor/layer_unittest.cc
diff --git a/ui/compositor/layer_unittest.cc b/ui/compositor/layer_unittest.cc
index 9056ffe52d10cdeb65e714f3a71b3535ecf638dc..580424ea2975b82f1f377769ce00280d6f9dea0f 100644
--- a/ui/compositor/layer_unittest.cc
+++ b/ui/compositor/layer_unittest.cc
@@ -210,7 +210,7 @@ class LayerWithRealCompositorTest : public testing::Test {
   void DrawTree(Layer* root) {
     GetCompositor()->SetRootLayer(root);
     GetCompositor()->ScheduleDraw();
-    WaitForSwap();
+    WaitForDraw();
   }
 
   void ReadPixels(SkBitmap* bitmap) {
@@ -244,9 +244,9 @@ class LayerWithRealCompositorTest : public testing::Test {
     ui::DrawWaiterForTest::WaitForCompositingStarted(GetCompositor());
   }
 
-  void WaitForSwap() {
-    DrawWaiterForTest::WaitForCompositingEnded(GetCompositor());
-  }
+  // void WaitForSwap() {

[Fady Samuel, 2017/03/27 18:36:18]

Delete this?

[Alex Z., 2017/03/27 18:52:38]

Done.

+  //   DrawWaiterForTest::WaitForCompositingEnded(GetCompositor());
+  // }
 
   void WaitForCommit() {
     ui::DrawWaiterForTest::WaitForCommit(GetCompositor());
@@ -390,12 +390,11 @@ class TestCompositorObserver : public CompositorObserver {
   TestCompositorObserver() = default;
 
   bool committed() const { return committed_; }
-  bool notified() const { return started_ && ended_; }
+  bool started() const { return started_; }
 
   void Reset() {
     committed_ = false;
     started_ = false;
-    ended_ = false;
   }
 
  private:
@@ -408,15 +407,12 @@ class TestCompositorObserver : public CompositorObserver {
     started_ = true;
   }
 
-  void OnCompositingEnded(Compositor* compositor) override { ended_ = true; }
-
   void OnCompositingLockStateChanged(Compositor* compositor) override {}
 
   void OnCompositingShuttingDown(Compositor* compositor) override {}
 
   bool committed_ = false;
   bool started_ = false;
-  bool ended_ = false;
 
   DISALLOW_COPY_AND_ASSIGN(TestCompositorObserver);
 };
@@ -1339,7 +1335,7 @@ TEST_F(LayerWithRealCompositorTest, CompositorObservers) {
   // Explicitly called DrawTree should cause the observers to be notified.
   // NOTE: this call to DrawTree sets l1 to be the compositor's root layer.
   DrawTree(l1.get());
-  EXPECT_TRUE(observer.notified());
+  EXPECT_TRUE(observer.started());
 
   // ScheduleDraw without any visible change should cause a commit.
   observer.Reset();
@@ -1350,26 +1346,26 @@ TEST_F(LayerWithRealCompositorTest, CompositorObservers) {
   // Moving, but not resizing, a layer should alert the observers.
   observer.Reset();
   l2->SetBounds(gfx::Rect(0, 0, 350, 350));
-  WaitForSwap();
-  EXPECT_TRUE(observer.notified());
+  WaitForDraw();
+  EXPECT_TRUE(observer.started());
 
   // So should resizing a layer.
   observer.Reset();
   l2->SetBounds(gfx::Rect(0, 0, 400, 400));
-  WaitForSwap();
-  EXPECT_TRUE(observer.notified());
+  WaitForDraw();
+  EXPECT_TRUE(observer.started());
 
   // Opacity changes should alert the observers.
   observer.Reset();
   l2->SetOpacity(0.5f);
-  WaitForSwap();
-  EXPECT_TRUE(observer.notified());
+  WaitForDraw();
+  EXPECT_TRUE(observer.started());
 
   // So should setting the opacity back.
   observer.Reset();
   l2->SetOpacity(1.0f);
-  WaitForSwap();
-  EXPECT_TRUE(observer.notified());
+  WaitForDraw();
+  EXPECT_TRUE(observer.started());
 
   // Setting the transform of a layer should alert the observers.
   observer.Reset();
@@ -1378,17 +1374,17 @@ TEST_F(LayerWithRealCompositorTest, CompositorObservers) {
   transform.Rotate(90.0);
   transform.Translate(-200.0, -200.0);
   l2->SetTransform(transform);
-  WaitForSwap();
-  EXPECT_TRUE(observer.notified());
+  WaitForDraw();
+  EXPECT_TRUE(observer.started());
 
   GetCompositor()->RemoveObserver(&observer);
 
   // Opacity changes should no longer alert the removed observer.
   observer.Reset();
   l2->SetOpacity(0.5f);
-  WaitForSwap();
+  WaitForDraw();
 
-  EXPECT_FALSE(observer.notified());
+  EXPECT_FALSE(observer.started());
 }
 
 // Checks that modifying the hierarchy correctly affects final composite.
@@ -2237,7 +2233,7 @@ TEST_F(LayerWithRealCompositorTest, CompositorAnimationObserverTest) {
   EXPECT_EQ(0u, animation_observer.animation_step_count());
 
   root->SetOpacity(0.5f);
-  WaitForSwap();
+  WaitForDraw();
   EXPECT_EQ(1u, animation_observer.animation_step_count());
 
   EXPECT_FALSE(animation_observer.shutdown());
@@ -2283,7 +2279,7 @@ TEST_F(LayerWithRealCompositorTest, ReportMetrics) {
   animation_sequence->SetAnimationMetricsReporter(&reporter);
   animator->StartAnimation(animation_sequence);
   while (!reporter.report_called())
-    WaitForSwap();
+    WaitForDraw();
   ResetCompositor();
   // Even though most of the time 100% smooth animations are expected, on the
   // test bots this cannot be guaranteed. Therefore simply check that some