chrome/browser/notifications/notification_system_observer.cc - Issue 2776933006: CrOS: Do not allow notifications to be added during shutdown.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/notifications/notification_system_observer.cc

Issue 2776933006: CrOS: Do not allow notifications to be added during shutdown. (Closed)

Patch Set: Trybots. Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/notifications/notification_system_observer.cc

diff --git a/chrome/browser/notifications/notification_system_observer.cc b/chrome/browser/notifications/notification_system_observer.cc

index 3285cdd0e2aadcc2561eab87f65770b9d188240d..b72bd80ca91151a1177043a61c461ff4b1d8d761 100644

--- a/chrome/browser/notifications/notification_system_observer.cc

+++ b/chrome/browser/notifications/notification_system_observer.cc

@@ -32,7 +32,7 @@ void NotificationSystemObserver::Observe(

const content::NotificationSource& source,

const content::NotificationDetails& details) {

if (type == chrome::NOTIFICATION_APP_TERMINATING) {

- ui_manager_->CancelAll();

+ ui_manager_->StartShutdown();

} else if (type == extensions::NOTIFICATION_EXTENSION_UNLOADED_DEPRECATED) {

if (!content::Source<Profile>(source)->IsOffTheRecord()) {

extensions::UnloadedExtensionInfo* extension_info =