Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1225)

Unified Diff: content/browser/renderer_host/input/render_widget_host_latency_tracker.cc

Issue 2776933004: Revert "Track input latency while starting a ServiceWorker for a navigation hint." (Closed)
Patch Set: rebase and fix indent Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/input/render_widget_host_latency_tracker.cc
diff --git a/content/browser/renderer_host/input/render_widget_host_latency_tracker.cc b/content/browser/renderer_host/input/render_widget_host_latency_tracker.cc
index e66f225f7b6a94afb48d0af5df1d2dee93659e62..8ebace902992f25699280254bcd8b17cf708a4a8 100644
--- a/content/browser/renderer_host/input/render_widget_host_latency_tracker.cc
+++ b/content/browser/renderer_host/input/render_widget_host_latency_tracker.cc
@@ -156,8 +156,7 @@ void ComputeScrollLatencyHistograms(
const LatencyInfo::LatencyComponent& gpu_swap_begin_component,
const LatencyInfo::LatencyComponent& gpu_swap_end_component,
int64_t latency_component_id,
- const LatencyInfo& latency,
- bool is_running_navigation_hint_task) {
+ const LatencyInfo& latency) {
DCHECK(!latency.coalesced());
if (latency.coalesced())
return;
@@ -176,17 +175,6 @@ void ComputeScrollLatencyHistograms(
"Event.Latency.TouchToFirstScrollUpdateSwapBegin",
original_component, gpu_swap_begin_component);
}
- // TODO(horo): IsRunningNavigationHintTask UMAs are only for
- // SpeculativeLaunchServiceWorker experimentation. So remove this UMA when
- // the experimentation finished (crbug.com/638827).
- if (is_running_navigation_hint_task) {
- for (size_t i = 0; i < original_component.event_count; i++) {
- UMA_HISTOGRAM_INPUT_LATENCY_HIGH_RESOLUTION_MICROSECONDS(
- "Event.Latency.TouchToFirstScrollUpdateSwapBegin_"
- "IsRunningNavigationHintTask",
- original_component, gpu_swap_begin_component);
- }
- }
} else if (!latency.FindLatency(
ui::INPUT_EVENT_LATENCY_SCROLL_UPDATE_ORIGINAL_COMPONENT,
latency_component_id, &original_component)) {
@@ -200,17 +188,6 @@ void ComputeScrollLatencyHistograms(
"Event.Latency.TouchToScrollUpdateSwapBegin", original_component,
gpu_swap_begin_component);
}
- // TODO(horo): IsRunningNavigationHintTask UMAs are only for
- // SpeculativeLaunchServiceWorker experimentation. So remove this UMA when
- // the experimentation finished (crbug.com/638827).
- if (is_running_navigation_hint_task) {
- for (size_t i = 0; i < original_component.event_count; i++) {
- UMA_HISTOGRAM_INPUT_LATENCY_HIGH_RESOLUTION_MICROSECONDS(
- "Event.Latency.TouchToScrollUpdateSwapBegin_"
- "IsRunningNavigationHintTask",
- original_component, gpu_swap_begin_component);
- }
- }
}
void ComputeTouchAndWheelScrollLatencyHistograms(
@@ -559,8 +536,7 @@ void RenderWidgetHostLatencyTracker::OnSwapCompositorFrame(
}
void RenderWidgetHostLatencyTracker::OnFrameSwapped(
- const LatencyInfo& latency,
- bool is_running_navigation_hint_task) {
+ const LatencyInfo& latency) {
LatencyInfo::LatencyComponent gpu_swap_end_component;
if (!latency.FindLatency(
ui::INPUT_EVENT_LATENCY_TERMINATED_FRAME_SWAP_COMPONENT, 0,
@@ -604,9 +580,9 @@ void RenderWidgetHostLatencyTracker::OnFrameSwapped(
if (!latency.FindLatency(
ui::INPUT_EVENT_LATENCY_GENERATE_SCROLL_UPDATE_FROM_MOUSE_WHEEL, 0,
&mouse_wheel_scroll_update_component)) {
- ComputeScrollLatencyHistograms(
- gpu_swap_begin_component, gpu_swap_end_component, latency_component_id_,
- latency, is_running_navigation_hint_task);
+ ComputeScrollLatencyHistograms(gpu_swap_begin_component,
+ gpu_swap_end_component,
+ latency_component_id_, latency);
}
}

Powered by Google App Engine
This is Rietveld 408576698