Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(325)

Unified Diff: Source/bindings/dart/DartCustomElementWrapper.cpp

Issue 27769002: Fixing custom element type extensions to have correct native type (Closed) Base URL: svn://svn.chromium.org/multivm/trunk/webkit
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: Source/bindings/dart/DartCustomElementWrapper.cpp
diff --git a/Source/bindings/dart/DartCustomElementWrapper.cpp b/Source/bindings/dart/DartCustomElementWrapper.cpp
index 569c7bfd8ae584d4a3d4665fadeb69299708458b..9328bed08458a27e4b7fe8e70510d70961c92cb1 100644
--- a/Source/bindings/dart/DartCustomElementWrapper.cpp
+++ b/Source/bindings/dart/DartCustomElementWrapper.cpp
@@ -114,8 +114,7 @@ Dart_Handle DartCustomElementWrapper<HTMLElement>::upgradeDartWrapper(HTMLElemen
Dart_Handle newInstance = Dart_Allocate(customType);
ASSERT(!Dart_IsError(newInstance));
- // TODO(14190): Use a more specific type instead of DartHTMLElement here.
- DartDOMWrapper::writeNativePointer(newInstance, element, DartHTMLElement::dartClassId);
+ DartDOMWrapper::writeNativePointer(newInstance, element, binding->nativeClassId());
Dart_Handle result = Dart_InvokeConstructor(newInstance, Dart_NewStringFromCString("created"), 0, 0);
@@ -134,7 +133,6 @@ Dart_Handle DartCustomElementWrapper<HTMLElement>::upgradeDartWrapper(HTMLElemen
Dart_Handle fallbackWrapper = createUpgradeCandidateWrapper(element, createSpecificWrapper);
DartDOMWrapper::associateWrapper<DartHTMLElement>(domData, element, fallbackWrapper);
- // TODO(14190): Use a more specific type instead of DartHTMLElement here.
DartDOMWrapper::writeNativePointer(fallbackWrapper, element, DartHTMLElement::dartClassId);
vsm 2013/10/18 21:18:15 Shouldn't the fallback wrapper still be binding->n
blois 2013/10/18 23:03:40 Done.
return fallbackWrapper;
}

Powered by Google App Engine
This is Rietveld 408576698