Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Unified Diff: media/blink/resource_multibuffer_data_provider.cc

Issue 2776853002: Make UMA_HISTOGRAM_ENUMERATION work with scoped enums. (Closed)
Patch Set: iOS, Windows, and CrOS compile fixes Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: media/blink/resource_multibuffer_data_provider.cc
diff --git a/media/blink/resource_multibuffer_data_provider.cc b/media/blink/resource_multibuffer_data_provider.cc
index f1f80f07823f60f9f15875d87437c18f44b13d8c..e812a97e53035434f2bb0194794187a550e8c97c 100644
--- a/media/blink/resource_multibuffer_data_provider.cc
+++ b/media/blink/resource_multibuffer_data_provider.cc
@@ -263,8 +263,8 @@ void ResourceMultiBufferDataProvider::didReceiveResponse(
while (reasons) {
DCHECK_LT(shift, max_enum); // Sanity check.
if (reasons & 0x1) {
- UMA_HISTOGRAM_ENUMERATION("Media.UncacheableReason", shift,
- max_enum); // PRESUBMIT_IGNORE_UMA_MAX
+ UMA_HISTOGRAM_EXACT_LINEAR("Media.UncacheableReason", shift,
rkaplow 2017/03/29 18:02:51 not sure why this can't be an enum either. Add a T
dcheng 2017/03/29 18:24:41 I think it's because the enum itself is a bitmask
rkaplow 2017/03/29 23:21:17 Well, the team can evaluate if they want to change
dcheng 2017/03/30 00:41:59 Done.
+ max_enum); // PRESUBMIT_IGNORE_UMA_MAX
}
reasons >>= 1;

Powered by Google App Engine
This is Rietveld 408576698