Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2719)

Unified Diff: chrome/browser/ui/page_info/page_info.cc

Issue 2776853002: Make UMA_HISTOGRAM_ENUMERATION work with scoped enums. (Closed)
Patch Set: iOS, Windows, and CrOS compile fixes Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/page_info/page_info.cc
diff --git a/chrome/browser/ui/page_info/page_info.cc b/chrome/browser/ui/page_info/page_info.cc
index d45117acce88cb60a7323d0ef9c2624e99fc6028..9b8d6942ba7148c5c80ed0dc68ed5d7bffac0fb8 100644
--- a/chrome/browser/ui/page_info/page_info.cc
+++ b/chrome/browser/ui/page_info/page_info.cc
@@ -278,11 +278,11 @@ void PageInfo::OnSitePermissionChanged(ContentSettingsType type,
// the Page Info UI.
size_t num_values;
int histogram_value = ContentSettingTypeToHistogramValue(type, &num_values);
- UMA_HISTOGRAM_ENUMERATION("WebsiteSettings.OriginInfo.PermissionChanged",
- histogram_value, num_values);
+ UMA_HISTOGRAM_EXACT_LINEAR("WebsiteSettings.OriginInfo.PermissionChanged",
+ histogram_value, num_values);
if (setting == ContentSetting::CONTENT_SETTING_ALLOW) {
- UMA_HISTOGRAM_ENUMERATION(
+ UMA_HISTOGRAM_EXACT_LINEAR(
"WebsiteSettings.OriginInfo.PermissionChanged.Allowed", histogram_value,
num_values);
@@ -292,7 +292,7 @@ void PageInfo::OnSitePermissionChanged(ContentSettingsType type,
"ContentSettings.Plugins.AddedAllowException", site_url_);
}
} else if (setting == ContentSetting::CONTENT_SETTING_BLOCK) {
- UMA_HISTOGRAM_ENUMERATION(
+ UMA_HISTOGRAM_EXACT_LINEAR(
"WebsiteSettings.OriginInfo.PermissionChanged.Blocked", histogram_value,
num_values);
}

Powered by Google App Engine
This is Rietveld 408576698