Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(34)

Side by Side Diff: chrome/browser/chromeos/login/screens/user_image_screen.cc

Issue 2776853002: Make UMA_HISTOGRAM_ENUMERATION work with scoped enums. (Closed)
Patch Set: iOS, Windows, and CrOS compile fixes Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/chromeos/login/screens/user_image_screen.h" 5 #include "chrome/browser/chromeos/login/screens/user_image_screen.h"
6 6
7 #include <string> 7 #include <string>
8 8
9 #include "base/bind.h" 9 #include "base/bind.h"
10 #include "base/bind_helpers.h" 10 #include "base/bind_helpers.h"
(...skipping 128 matching lines...) Expand 10 before | Expand all | Expand 10 after
139 break; 139 break;
140 default: 140 default:
141 DCHECK(selected_image_ >= 0 && 141 DCHECK(selected_image_ >= 0 &&
142 selected_image_ < default_user_image::kDefaultImagesCount); 142 selected_image_ < default_user_image::kDefaultImagesCount);
143 image_manager->SaveUserDefaultImageIndex(selected_image_); 143 image_manager->SaveUserDefaultImageIndex(selected_image_);
144 uma_index = 144 uma_index =
145 default_user_image::GetDefaultImageHistogramValue(selected_image_); 145 default_user_image::GetDefaultImageHistogramValue(selected_image_);
146 break; 146 break;
147 } 147 }
148 if (user_has_selected_image_) { 148 if (user_has_selected_image_) {
149 UMA_HISTOGRAM_ENUMERATION("UserImage.FirstTimeChoice", uma_index, 149 UMA_HISTOGRAM_EXACT_LINEAR("UserImage.FirstTimeChoice", uma_index,
wychen 2017/03/27 20:08:56 If these constants are converted to enum, uma_inde
150 default_user_image::kHistogramImagesCount); 150 default_user_image::kHistogramImagesCount);
151 } 151 }
152 ExitScreen(); 152 ExitScreen();
153 } 153 }
154 154
155 void UserImageScreen::OnViewDestroyed(UserImageView* view) { 155 void UserImageScreen::OnViewDestroyed(UserImageView* view) {
156 if (view_ == view) 156 if (view_ == view)
157 view_ = nullptr; 157 view_ = nullptr;
158 } 158 }
159 159
160 void UserImageScreen::Show() { 160 void UserImageScreen::Show() {
(...skipping 171 matching lines...) Expand 10 before | Expand all | Expand 10 after
332 332
333 void UserImageScreen::ReportSyncResult(SyncResult timed_out) const { 333 void UserImageScreen::ReportSyncResult(SyncResult timed_out) const {
334 base::TimeDelta duration = base::Time::Now() - sync_waiting_start_time_; 334 base::TimeDelta duration = base::Time::Now() - sync_waiting_start_time_;
335 UMA_HISTOGRAM_TIMES("Login.NewUserPriorityPrefsSyncTime", duration); 335 UMA_HISTOGRAM_TIMES("Login.NewUserPriorityPrefsSyncTime", duration);
336 UMA_HISTOGRAM_ENUMERATION("Login.NewUserPriorityPrefsSyncResult", 336 UMA_HISTOGRAM_ENUMERATION("Login.NewUserPriorityPrefsSyncResult",
337 static_cast<int>(timed_out), 337 static_cast<int>(timed_out),
338 static_cast<int>(SyncResult::COUNT)); 338 static_cast<int>(SyncResult::COUNT));
339 } 339 }
340 340
341 } // namespace chromeos 341 } // namespace chromeos
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698