Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(240)

Unified Diff: src/compiler/x64/code-generator-x64.cc

Issue 2776753004: [wasm] Make Opcode names consistent across architectures, implementations (Closed)
Patch Set: Fix Saturates Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/compiler/wasm-compiler.cc ('k') | src/compiler/x64/instruction-codes-x64.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/compiler/x64/code-generator-x64.cc
diff --git a/src/compiler/x64/code-generator-x64.cc b/src/compiler/x64/code-generator-x64.cc
index 443dc81dd34a1eeebf642a18661fa11b1f72f76a..f1f3855bfd9a9484d0006ba25963452dcbfd73ae 100644
--- a/src/compiler/x64/code-generator-x64.cc
+++ b/src/compiler/x64/code-generator-x64.cc
@@ -2142,18 +2142,18 @@ CodeGenerator::CodeGenResult CodeGenerator::AssembleArchInstruction(
}
break;
}
- case kX64Int32x4Splat: {
+ case kX64I32x4Splat: {
XMMRegister dst = i.OutputSimd128Register();
__ movd(dst, i.InputRegister(0));
__ pshufd(dst, dst, 0x0);
break;
}
- case kX64Int32x4ExtractLane: {
+ case kX64I32x4ExtractLane: {
CpuFeatureScope sse_scope(masm(), SSE4_1);
__ Pextrd(i.OutputRegister(), i.InputSimd128Register(0), i.InputInt8(1));
break;
}
- case kX64Int32x4ReplaceLane: {
+ case kX64I32x4ReplaceLane: {
CpuFeatureScope sse_scope(masm(), SSE4_1);
if (instr->InputAt(2)->IsRegister()) {
__ Pinsrd(i.OutputSimd128Register(), i.InputRegister(2),
@@ -2163,62 +2163,67 @@ CodeGenerator::CodeGenResult CodeGenerator::AssembleArchInstruction(
}
break;
}
- case kX64Int32x4Add: {
+ case kX64I32x4Shl: {
+ __ pslld(i.OutputSimd128Register(), i.InputInt8(1));
+ break;
+ }
+ case kX64I32x4ShrS: {
+ __ psrad(i.OutputSimd128Register(), i.InputInt8(1));
+ break;
+ }
+ case kX64I32x4Add: {
__ paddd(i.OutputSimd128Register(), i.InputSimd128Register(1));
break;
}
- case kX64Int32x4Sub: {
+ case kX64I32x4Sub: {
__ psubd(i.OutputSimd128Register(), i.InputSimd128Register(1));
break;
}
- case kX64Int32x4Mul: {
+ case kX64I32x4Mul: {
CpuFeatureScope sse_scope(masm(), SSE4_1);
__ pmulld(i.OutputSimd128Register(), i.InputSimd128Register(1));
break;
}
- case kX64Int32x4Min: {
+ case kX64I32x4MinS: {
CpuFeatureScope sse_scope(masm(), SSE4_1);
__ pminsd(i.OutputSimd128Register(), i.InputSimd128Register(1));
break;
}
- case kX64Int32x4Max: {
+ case kX64I32x4MaxS: {
CpuFeatureScope sse_scope(masm(), SSE4_1);
__ pmaxsd(i.OutputSimd128Register(), i.InputSimd128Register(1));
break;
}
- case kX64Uint32x4Min: {
- CpuFeatureScope sse_scope(masm(), SSE4_1);
- __ pminud(i.OutputSimd128Register(), i.InputSimd128Register(1));
- break;
- }
- case kX64Uint32x4Max: {
- CpuFeatureScope sse_scope(masm(), SSE4_1);
- __ pmaxud(i.OutputSimd128Register(), i.InputSimd128Register(1));
- break;
- }
- case kX64Int32x4Equal: {
+ case kX64I32x4Eq: {
__ pcmpeqd(i.OutputSimd128Register(), i.InputSimd128Register(1));
break;
}
- case kX64Int32x4NotEqual: {
+ case kX64I32x4Ne: {
__ pcmpeqd(i.OutputSimd128Register(), i.InputSimd128Register(1));
__ pcmpeqd(kScratchDoubleReg, kScratchDoubleReg);
__ pxor(i.OutputSimd128Register(), kScratchDoubleReg);
break;
}
- case kX64Int32x4ShiftLeftByScalar: {
- __ pslld(i.OutputSimd128Register(), i.InputInt8(1));
+ case kX64I32x4ShrU: {
+ __ psrld(i.OutputSimd128Register(), i.InputInt8(1));
break;
}
- case kX64Int32x4ShiftRightByScalar: {
- __ psrad(i.OutputSimd128Register(), i.InputInt8(1));
+ case kX64I32x4MinU: {
+ CpuFeatureScope sse_scope(masm(), SSE4_1);
+ __ pminud(i.OutputSimd128Register(), i.InputSimd128Register(1));
break;
}
- case kX64Uint32x4ShiftRightByScalar: {
- __ psrld(i.OutputSimd128Register(), i.InputInt8(1));
+ case kX64I32x4MaxU: {
+ CpuFeatureScope sse_scope(masm(), SSE4_1);
+ __ pmaxud(i.OutputSimd128Register(), i.InputSimd128Register(1));
break;
}
- case kX64Simd32x4Select: {
+ case kX64S128Zero: {
+ XMMRegister dst = i.OutputSimd128Register();
+ __ xorps(dst, dst);
+ break;
+ }
+ case kX64S32x4Select: {
// Mask used here is stored in dst.
XMMRegister dst = i.OutputSimd128Register();
__ movaps(kScratchDoubleReg, i.InputSimd128Register(1));
@@ -2227,11 +2232,6 @@ CodeGenerator::CodeGenResult CodeGenerator::AssembleArchInstruction(
__ xorps(dst, i.InputSimd128Register(2));
break;
}
- case kX64Simd128Zero: {
- XMMRegister dst = i.OutputSimd128Register();
- __ xorps(dst, dst);
- break;
- }
case kCheckedLoadInt8:
ASSEMBLE_CHECKED_LOAD_INTEGER(movsxbl);
break;
« no previous file with comments | « src/compiler/wasm-compiler.cc ('k') | src/compiler/x64/instruction-codes-x64.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698