Issue 2776733002: Include CompilationUnit begin/endToken(s) with Fasta.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2776733002: Include CompilationUnit begin/endToken(s) with Fasta. (Closed)

Created:
3 years, 9 months ago by scheglov

Modified:
3 years, 9 months ago

Reviewers:
Paul Berry

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Created: 3 years, 9 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -4 lines)			Patch
	M	pkg/analyzer/lib/src/fasta/ast_builder.dart	View		2 chunks	+10 lines, -4 lines	0 comments	Download
	M	pkg/analyzer/test/generated/parser_test.dart	View	1	2 chunks	+7 lines, -0 lines	0 comments	Download

Total messages: 4 (1 generated)

Paul Berry

Can we add a test verifying that this works? If so, lgtm.

3 years, 9 months ago (2017-03-24 17:44:59 UTC) #2

scheglov

3 years, 9 months ago (2017-03-24 18:47:12 UTC) #4

Message was sent while issue was closed.

Committed patchset #2 (id:20001) manually as
4f6882d61767296bcf72eb605405a0667ed7e3ab (presubmit successful).