Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(187)

Unified Diff: Source/bindings/dart/DartUtilities.cpp

Issue 27767003: Convert serialized values to ints if they are whole and less than 53 bits. (Closed) Base URL: svn://svn.chromium.org/multivm/trunk/webkit
Patch Set: Created 7 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/bindings/dart/DartUtilities.h ('k') | Source/bindings/dart/V8Converter.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/dart/DartUtilities.cpp
diff --git a/Source/bindings/dart/DartUtilities.cpp b/Source/bindings/dart/DartUtilities.cpp
index 9326acf8ac5292d6643a7773997d8daa950da27b..a79027f87443bd79f56eb6ea08ea895872f77dae 100644
--- a/Source/bindings/dart/DartUtilities.cpp
+++ b/Source/bindings/dart/DartUtilities.cpp
@@ -50,6 +50,8 @@
#include "core/platform/network/ResourceRequest.h"
#include "core/platform/sql/SQLValue.h"
+#include <math.h>
+
#include <wtf/ArrayBufferView.h>
#include <wtf/Float32Array.h>
#include <wtf/Float64Array.h>
@@ -281,8 +283,9 @@ unsigned long long DartUtilities::dartToUnsignedLongLong(Dart_Handle object, Dar
Dart_Handle DartUtilities::numberToDart(double value)
{
- int intValue = static_cast<int>(value);
- if (value == intValue)
+ int64_t intValue = static_cast<int64_t>(value);
+ // JS can store integer values that are no greater than 2^53.
+ if (value == intValue && abs(intValue) <= pow(2, 53))
sra1 2013/10/17 21:40:31 I would avoid calling pow and define a constant kM
Emily Fortuna 2013/10/17 22:42:51 Gotcha. Sorry I was going off of this: http://ecma
return intToDart(intValue);
return doubleToDart(value);
}
« no previous file with comments | « Source/bindings/dart/DartUtilities.h ('k') | Source/bindings/dart/V8Converter.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698