Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(292)

Unified Diff: tracing/tracing/model/helpers/chrome_browser_helper.html

Issue 2776653002: [ESLint] Fix violations when enabling curly rule in eslint. (Closed)
Patch Set: Fix test Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tracing/tracing/model/helpers/chrome_browser_helper.html
diff --git a/tracing/tracing/model/helpers/chrome_browser_helper.html b/tracing/tracing/model/helpers/chrome_browser_helper.html
index 8da03be35351cd88af1fd1a49555a52c9937855b..81bd98a20099863c27338a520d7326cf87490a72 100644
--- a/tracing/tracing/model/helpers/chrome_browser_helper.html
+++ b/tracing/tracing/model/helpers/chrome_browser_helper.html
@@ -18,8 +18,9 @@ tr.exportTo('tr.model.helpers', function() {
function ChromeBrowserHelper(modelHelper, process) {
tr.model.helpers.ChromeProcessHelper.call(this, modelHelper, process);
this.mainThread_ = process.findAtMostOneThreadNamed('CrBrowserMain');
- if (!process.name)
+ if (!process.name) {
process.name = ChromeBrowserHelper.PROCESS_NAME;
+ }
}
ChromeBrowserHelper.PROCESS_NAME = 'Browser';
@@ -65,14 +66,15 @@ tr.exportTo('tr.model.helpers', function() {
get hasLatencyEvents() {
var hasLatency = false;
- for (var thread of this.modelHelper.model.getAllThreads())
+ for (var thread of this.modelHelper.model.getAllThreads()) {
for (var event of thread.getDescendantEvents()) {
- if (!event.isTopLevel)
- continue;
- if (!(event instanceof tr.e.cc.InputLatencyAsyncSlice))
+ if (!event.isTopLevel) continue;
+ if (!(event instanceof tr.e.cc.InputLatencyAsyncSlice)) {
continue;
+ }
hasLatency = true;
}
+ }
return hasLatency;
},
@@ -87,9 +89,11 @@ tr.exportTo('tr.model.helpers', function() {
getAllAsyncSlicesMatching: function(pred, opt_this) {
var events = [];
this.iterAllThreads(function(thread) {
- for (var slice of thread.getDescendantEvents())
- if (pred.call(opt_this, slice))
+ for (var slice of thread.getDescendantEvents()) {
+ if (pred.call(opt_this, slice)) {
events.push(slice);
+ }
+ }
});
return events;
},
@@ -105,12 +109,12 @@ tr.exportTo('tr.model.helpers', function() {
match = true;
}
- if (!match)
- return;
+ if (!match) return;
if (rangeOfInterest.intersectsExplicitRangeInclusive(
- slice.start, slice.end))
+ slice.start, slice.end)) {
networkEvents.push(slice);
+ }
});
});
return networkEvents;

Powered by Google App Engine
This is Rietveld 408576698