Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(682)

Unified Diff: components/sessions/core/serialized_navigation_entry.cc

Issue 2776633003: Add taskid for navigation, created in session sync (Closed)
Patch Set: comments and refactoring Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/sessions/core/serialized_navigation_entry.cc
diff --git a/components/sessions/core/serialized_navigation_entry.cc b/components/sessions/core/serialized_navigation_entry.cc
index ca686b0add4feaa9f0568128ead68ed1b5836604..af42e98f468e6eedd2bc17dc8c8dd7bd02e0d9bd 100644
--- a/components/sessions/core/serialized_navigation_entry.cc
+++ b/components/sessions/core/serialized_navigation_entry.cc
@@ -498,22 +498,26 @@ sync_pb::TabNavigation SerializedNavigationEntry::ToSyncData() const {
sync_data.set_is_restored(is_restored_);
+ sync_pb::TaskId task_id;
+ for (const auto& node_id : task_id_)
+ task_id.add_task_node_id(node_id);
+ *sync_data.mutable_task_id() = task_id;
+
return sync_data;
}
size_t SerializedNavigationEntry::EstimateMemoryUsage() const {
using base::trace_event::EstimateMemoryUsage;
- return
- EstimateMemoryUsage(referrer_url_) +
- EstimateMemoryUsage(virtual_url_) +
- EstimateMemoryUsage(title_) +
- EstimateMemoryUsage(encoded_page_state_) +
- EstimateMemoryUsage(original_request_url_) +
- EstimateMemoryUsage(search_terms_) +
- EstimateMemoryUsage(favicon_url_) +
- EstimateMemoryUsage(redirect_chain_) +
- EstimateMemoryUsage(content_pack_categories_) +
- EstimateMemoryUsage(extended_info_map_);
+ return EstimateMemoryUsage(referrer_url_) +
+ EstimateMemoryUsage(virtual_url_) + EstimateMemoryUsage(title_) +
+ EstimateMemoryUsage(encoded_page_state_) +
+ EstimateMemoryUsage(original_request_url_) +
+ EstimateMemoryUsage(search_terms_) +
+ EstimateMemoryUsage(favicon_url_) +
+ EstimateMemoryUsage(redirect_chain_) +
+ EstimateMemoryUsage(content_pack_categories_) +
+ EstimateMemoryUsage(extended_info_map_) +
+ EstimateMemoryUsage(task_id_);
}
} // namespace sessions

Powered by Google App Engine
This is Rietveld 408576698