Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(603)

Unified Diff: components/sync_sessions/sessions_sync_manager_unittest.cc

Issue 2776633003: Add taskid for navigation, created in session sync (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/sync_sessions/sessions_sync_manager_unittest.cc
diff --git a/components/sync_sessions/sessions_sync_manager_unittest.cc b/components/sync_sessions/sessions_sync_manager_unittest.cc
index ab5cbfde94db4bca324d1de09698e5347f57bed4..959cb475bbc13806ddd17586d8535d20240a826e 100644
--- a/components/sync_sessions/sessions_sync_manager_unittest.cc
+++ b/components/sync_sessions/sessions_sync_manager_unittest.cc
@@ -794,7 +794,7 @@ TEST_F(SessionsSyncManagerTest, SetSessionTabFromDelegate) {
SerializedNavigationEntryTestHelper::CreateNavigation(
"http://www.example.com", "Example"));
session_tab.session_storage_persistent_id = "persistent id";
- manager()->SetSessionTabFromDelegate(*tab, kTime4, &session_tab);
+ manager()->SetSessionTabFromDelegate(*tab, kTime4, &session_tab, nullptr);
EXPECT_EQ(tab->GetWindowId(), session_tab.window_id.id());
EXPECT_EQ(tab->GetSessionId(), session_tab.tab_id.id());
@@ -834,7 +834,7 @@ TEST_F(SessionsSyncManagerTest, SetSessionTabFromDelegateNavigationIndex) {
tab->set_current_entry_index(kNavs - 2);
sessions::SessionTab session_tab;
- manager()->SetSessionTabFromDelegate(*tab, kTime9, &session_tab);
+ manager()->SetSessionTabFromDelegate(*tab, kTime9, &session_tab, nullptr);
EXPECT_EQ(6, session_tab.current_navigation_index);
ASSERT_EQ(8u, session_tab.navigations.size());
@@ -854,7 +854,7 @@ TEST_F(SessionsSyncManagerTest, SetSessionTabFromDelegateCurrentInvalid) {
tab->set_current_entry_index(1);
sessions::SessionTab session_tab;
- manager()->SetSessionTabFromDelegate(*tab, kTime9, &session_tab);
+ manager()->SetSessionTabFromDelegate(*tab, kTime9, &session_tab, nullptr);
EXPECT_EQ(2, session_tab.current_navigation_index);
ASSERT_EQ(3u, session_tab.navigations.size());
@@ -897,7 +897,7 @@ TEST_F(SessionsSyncManagerTest, BlockedNavigations) {
SerializedNavigationEntryTestHelper::CreateNavigation(
"http://www.example.com", "Example"));
session_tab.session_storage_persistent_id = "persistent id";
- manager()->SetSessionTabFromDelegate(*tab, kTime4, &session_tab);
+ manager()->SetSessionTabFromDelegate(*tab, kTime4, &session_tab, nullptr);
EXPECT_EQ(tab->GetWindowId(), session_tab.window_id.id());
EXPECT_EQ(tab->GetSessionId(), session_tab.tab_id.id());

Powered by Google App Engine
This is Rietveld 408576698