Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(230)

Side by Side Diff: components/sync/protocol/session_specifics.proto

Issue 2776633003: Add taskid for navigation, created in session sync (Closed)
Patch Set: comments and refactoring Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 // 4 //
5 // Sync protocol datatype extension for sessions. 5 // Sync protocol datatype extension for sessions.
6 6
7 // Update proto_value_conversions{.h,.cc,_unittest.cc} if you change 7 // Update proto_value_conversions{.h,.cc,_unittest.cc} if you change
8 // any fields in this file. 8 // any fields in this file.
9 9
10 syntax = "proto2"; 10 syntax = "proto2";
(...skipping 138 matching lines...) Expand 10 before | Expand all | Expand 10 after
149 // third_party/WebKit/public/platform/WebReferrerPolicy.h. 149 // third_party/WebKit/public/platform/WebReferrerPolicy.h.
150 optional int32 correct_referrer_policy = 25 [default = 1]; 150 optional int32 correct_referrer_policy = 25 [default = 1];
151 151
152 enum PasswordState { 152 enum PasswordState {
153 PASSWORD_STATE_UNKNOWN = 0; 153 PASSWORD_STATE_UNKNOWN = 0;
154 NO_PASSWORD_FIELD = 1; 154 NO_PASSWORD_FIELD = 1;
155 HAS_PASSWORD_FIELD = 2; 155 HAS_PASSWORD_FIELD = 2;
156 } 156 }
157 // Whether the Password Manager saw a password field on the page. 157 // Whether the Password Manager saw a password field on the page.
158 optional PasswordState password_state = 26; 158 optional PasswordState password_state = 26;
159
160 // Id of the task associated with this navigation.
161 optional TaskId task_id = 27;
162 }
163
164 // Task id which recursively encodes id of its parent task. From one task id,
165 // we can get ids of its all ancester tasks.
Nicolas Zea 2017/03/27 20:43:52 Explain what a task node id is (namely a GUID that
shenchao 2017/04/06 00:54:55 Done.
166 // E.g. if current task id is
167 // {
168 // task_node_id:1
169 // task_node_id:2
170 // task_node_id:3
171 // }, then id of its parent task is
172 // {
173 // task_node_id:1
174 // task_node_id:2
175 // }, and id of its grandparent task, which is a root task is
176 // {
177 // task_node_id:1
178 // }
179 message TaskId {
180 // A list of node ids, not encoding parent node, for task path of (root,
181 // ..., parent, current task).
182 repeated int64 task_node_id = 1;
Nicolas Zea 2017/03/27 20:43:52 Should we bother encoding the current task id/ It'
shenchao 2017/04/04 18:37:50 Just found we can't use global_id, which changes w
159 } 183 }
160 184
161 // Navigation information for a single redirection within a single navigation. 185 // Navigation information for a single redirection within a single navigation.
162 message NavigationRedirect { 186 message NavigationRedirect {
163 // A URL that redirected while navigating to the virtual_url. 187 // A URL that redirected while navigating to the virtual_url.
164 optional string url = 1; 188 optional string url = 1;
165 } 189 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698