Add taskid for navigation, created in session sync

components/sessions/core/serialized_navigation_entry.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_SESSIONS_CORE_SERIALIZED_NAVIGATION_ENTRY_H_
 #define COMPONENTS_SESSIONS_CORE_SERIALIZED_NAVIGATION_ENTRY_H_
 
 #include <stdint.h>
 
 #include <map>
@@ skipping 110 matching lines @@
   void set_content_pack_categories(
       const std::set<std::string>& content_pack_categories) {
     content_pack_categories_ = content_pack_categories;
   }
   const std::vector<GURL>& redirect_chain() const { return redirect_chain_; }
 
   const std::map<std::string, std::string>& extended_info_map() const {
     return extended_info_map_;
   }
 
+  const std::vector<int64_t>& get_task_id() const { return task_id_; }
+  void set_task_id(const std::vector<int64_t>& task_id) { task_id_ = task_id; }
+
   size_t EstimateMemoryUsage() const;
 
  private:
   friend class ContentSerializedNavigationBuilder;
   friend class ContentSerializedNavigationDriver;
   friend class SerializedNavigationEntryTestHelper;
   friend class IOSSerializedNavigationBuilder;
   friend class IOSSerializedNavigationDriver;
 
   // Index in the NavigationController.
@@ skipping 12 matching lines @@
   bool has_post_data_;
   int64_t post_id_;
   GURL original_request_url_;
   bool is_overriding_user_agent_;
   base::Time timestamp_;
   base::string16 search_terms_;
   GURL favicon_url_;
   int http_status_code_;
   bool is_restored_;    // Not persisted.
   std::vector<GURL> redirect_chain_;  // Not persisted.
+  std::vector<int64_t> task_id_;

[Nicolas Zea, 2017/03/27 20:43:52]

This class is exclusively meant to wrap data stored within a NavigationEntry. As
such, I don't think this is the right place for this task id to live.

What we probably need to do is stop using the SerializedNavigationEntry directly
in the SessionsSyncManager, and instead have our own wrapper around it (e.g.
SyncSessionTab).

[shenchao, 2017/04/06 00:54:55]

Acknowledged. Stopped using the SerializedNavigationEntry, but maybe leaving
having a new wrapper as future work.

 
   // Additional information.
   BlockedState blocked_state_;
   PasswordState password_state_;
   std::set<std::string> content_pack_categories_;
 
   // Provides storage for arbitrary key/value pairs used by features. This
   // data is not synced.
   std::map<std::string, std::string> extended_info_map_;
 };
 
 }  // namespace sessions
 
 #endif  // COMPONENTS_SESSIONS_CORE_SERIALIZED_NAVIGATION_ENTRY_H_