Add taskid for navigation, created in session sync

components/sessions/core/serialized_navigation_entry.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef COMPONENTS_SESSIONS_CORE_SERIALIZED_NAVIGATION_ENTRY_H_
 #define COMPONENTS_SESSIONS_CORE_SERIALIZED_NAVIGATION_ENTRY_H_
 
 #include <stdint.h>
 
 #include <map>
@@ skipping 61 matching lines @@
       const sync_pb::TabNavigation& sync_data);
 
   // Note that not all SerializedNavigationEntry fields are preserved.
   // |max_size| is the max number of bytes to write.
   void WriteToPickle(int max_size, base::Pickle* pickle) const;
   bool ReadFromPickle(base::PickleIterator* iterator);
 
   // Convert this navigation into its sync protocol buffer equivalent.  Note
   // that the protocol buffer doesn't contain all SerializedNavigationEntry
   // fields.
   sync_pb::TabNavigation ToSyncData() const;

[Patrick Noland, 2017/03/24 20:51:57]

I think you'll need to update the definition of ToSyncData to set the task ids
on the returned TabNavigation

[shenchao, 2017/03/25 23:53:13]

Done.

 
   // The index in the NavigationController. This SerializedNavigationEntry is
   // valid only when the index is non-negative.
   int index() const { return index_; }
   void set_index(int index) { index_ = index; }
 
   // Accessors for some fields taken from NavigationEntry.
   int unique_id() const { return unique_id_; }
   const GURL& virtual_url() const { return virtual_url_; }
   const base::string16& title() const { return title_; }
@@ skipping 28 matching lines @@
   void set_content_pack_categories(
       const std::set<std::string>& content_pack_categories) {
     content_pack_categories_ = content_pack_categories;
   }
   const std::vector<GURL>& redirect_chain() const { return redirect_chain_; }
 
   const std::map<std::string, std::string>& extended_info_map() const {
     return extended_info_map_;
   }
 
+  const std::vector<int64_t>& get_task_id() const { return task_id_; }
+  void set_task_id(const std::vector<int64_t>& task_id) { task_id_ = task_id; }
+
   size_t EstimateMemoryUsage() const;
 
  private:
   friend class ContentSerializedNavigationBuilder;
   friend class ContentSerializedNavigationDriver;
   friend class SerializedNavigationEntryTestHelper;
   friend class IOSSerializedNavigationBuilder;
   friend class IOSSerializedNavigationDriver;
 
   // Index in the NavigationController.
@@ skipping 21 matching lines @@
   std::vector<GURL> redirect_chain_;  // Not persisted.
 
   // Additional information.
   BlockedState blocked_state_;
   PasswordState password_state_;
   std::set<std::string> content_pack_categories_;
 
   // Provides storage for arbitrary key/value pairs used by features. This
   // data is not synced.
   std::map<std::string, std::string> extended_info_map_;
+
+  // Task id of a Chrome task, which is prefixed by its parent task.

[Patrick Noland, 2017/03/24 20:51:57]

Can you explain the prefixing more fully; i.e. it's not prefixed by just its
parent, but all the way up to the root.

[shenchao, 2017/03/25 23:53:13]

Move it above to the variables corresponding to NavigationEntry fields, so
people can go to proto to see explanation

+  std::vector<int64_t> task_id_;
 };
 
 }  // namespace sessions
 
 #endif  // COMPONENTS_SESSIONS_CORE_SERIALIZED_NAVIGATION_ENTRY_H_