Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3263)

Unified Diff: chrome/BUILD.gn

Issue 2776613002: media: Move Widevine signature of Framework into a bundle (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/common/media/cdm_host_file_path.cc » ('j') | chrome/common/media/cdm_host_file_path.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/BUILD.gn
diff --git a/chrome/BUILD.gn b/chrome/BUILD.gn
index c14a75d3e16051acb4eec704eabc23a83d9baf7f..1347539cf82d7430c707b3219caf09e56917bacd 100644
--- a/chrome/BUILD.gn
+++ b/chrome/BUILD.gn
@@ -661,8 +661,8 @@ if (is_win) {
# Only official builds that include Widevine need the widevine
# signature file.
if (is_chrome_branded && enable_pepper_cdms) {
- sources += [ "$root_out_dir/$chrome_framework_name.sig" ]
- public_deps += [ ":sign_chrome_framework_for_widevine" ]
+ sources += [ "$root_out_dir/Widevine Signature.bundle" ]
Greg K 2017/03/24 00:04:41 Can we call this Widevine Resources.bundle instead
xhwang 2017/03/24 00:23:26 I am totally flexible on the naming so I'll wait f
+ public_deps += [ ":widevine_signature_bundle" ]
}
}
@@ -936,6 +936,30 @@ if (is_win) {
":chrome_framework",
]
}
+
+ bundle_data("framework_widevine_signature") {
+ sources = [
+ "$root_out_dir/$chrome_framework_name.sig",
+ ]
+
+ outputs = [
+ "{{bundle_resources_dir}}/{{source_file_part}}",
+ ]
+
+ public_deps = [
+ ":sign_chrome_framework_for_widevine",
+ ]
+ }
+
+ create_bundle("widevine_signature_bundle") {
+ output_name = "Widevine Signature.bundle"
+ bundle_root_dir = "$root_build_dir/$output_name/Contents"
+ bundle_resources_dir = bundle_root_dir + "/Resources"
+
+ deps = [
+ ":framework_widevine_signature",
+ ]
+ }
}
group("widevine_cdm_library") {
« no previous file with comments | « no previous file | chrome/common/media/cdm_host_file_path.cc » ('j') | chrome/common/media/cdm_host_file_path.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698