Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(367)

Unified Diff: components/cronet/ios/test/test_server.cc

Issue 2776583004: Use 64kb read buffer in CRNHttpProtocolHandler on iOS. (Closed)
Patch Set: Address Andrei's comments, use RawHttpResponse. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/cronet/ios/test/test_server.cc
diff --git a/components/cronet/ios/test/test_server.cc b/components/cronet/ios/test/test_server.cc
index 1d549a079fb2768e82d1586ac6a53fe7891c3e5e..3207b51014fa0acdfe5e5db2b7414cd358e9b93a 100644
--- a/components/cronet/ios/test/test_server.cc
+++ b/components/cronet/ios/test/test_server.cc
@@ -7,8 +7,12 @@
#include <utility>
#include "base/bind.h"
+#include "base/format_macros.h"
+#include "base/lazy_instance.h"
#include "base/memory/ptr_util.h"
+#include "base/strings/string_number_conversions.h"
#include "base/strings/string_util.h"
+#include "base/strings/stringprintf.h"
#include "net/test/embedded_test_server/embedded_test_server.h"
#include "net/test/embedded_test_server/http_request.h"
#include "net/test/embedded_test_server/http_response.h"
@@ -17,8 +21,11 @@ namespace {
const char kEchoHeaderPath[] = "/EchoHeader?";
const char kSetCookiePath[] = "/SetCookie?";
+const char kBigDataPath[] = "/BigData";
std::unique_ptr<net::EmbeddedTestServer> g_test_server;
+base::LazyInstance<std::string>::Leaky g_big_data_body =
+ LAZY_INSTANCE_INITIALIZER;
std::unique_ptr<net::test_server::HttpResponse> EchoHeaderInRequest(
const net::test_server::HttpRequest& request) {
@@ -36,6 +43,14 @@ std::unique_ptr<net::test_server::HttpResponse> EchoHeaderInRequest(
return std::move(http_response);
}
+std::unique_ptr<net::test_server::HttpResponse> ReturnBigDataInResponse(
+ const net::test_server::HttpRequest& request) {
+ DCHECK(base::StartsWith(request.relative_url, kBigDataPath,
+ base::CompareCase::INSENSITIVE_ASCII));
+ return base::MakeUnique<net::test_server::RawHttpResponse>(
+ std::string(), g_big_data_body.Get());
+}
+
std::unique_ptr<net::test_server::HttpResponse> SetAndEchoCookieInResponse(
const net::test_server::HttpRequest& request) {
std::string cookie_line;
@@ -58,6 +73,10 @@ std::unique_ptr<net::test_server::HttpResponse> CronetTestRequestHandler(
base::CompareCase::INSENSITIVE_ASCII)) {
return SetAndEchoCookieInResponse(request);
}
+ if (base::StartsWith(request.relative_url, kBigDataPath,
+ base::CompareCase::INSENSITIVE_ASCII)) {
+ return ReturnBigDataInResponse(request);
+ }
return base::MakeUnique<net::test_server::BasicHttpResponse>();
}
@@ -90,4 +109,17 @@ std::string TestServer::GetSetCookieURL(const std::string& cookie_line) {
return g_test_server->GetURL(kSetCookiePath + cookie_line).spec();
}
+std::string TestServer::PrepareBigDataURL(long data_size) {
+ DCHECK(g_test_server);
+ // Response line with headers.
kapishnikov 2017/04/19 18:19:01 Since g_big_data_body is global, can we add a chec
mef 2017/04/19 19:04:48 Done.
+ std::string response_builder;
+ base::StringAppendF(&response_builder, "HTTP/1.1 200 OK\r\n");
+ base::StringAppendF(&response_builder, "Content-Length: %" PRIuS "\r\n",
+ data_size);
+ base::StringAppendF(&response_builder, "\r\n");
+ response_builder += std::string(data_size, 'c');
+ g_big_data_body.Get() = response_builder;
+ return g_test_server->GetURL(kBigDataPath).spec();
+}
+
} // namespace cronet

Powered by Google App Engine
This is Rietveld 408576698