Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1784)

Unified Diff: third_party/WebKit/Source/core/layout/compositing/CompositingReasonFinder.h

Issue 2776563003: Only automatically promote sticky position elements which move with scroll. (Closed)
Patch Set: Merge with master Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/compositing/CompositingReasonFinder.h
diff --git a/third_party/WebKit/Source/core/layout/compositing/CompositingReasonFinder.h b/third_party/WebKit/Source/core/layout/compositing/CompositingReasonFinder.h
index dfb2f8b1817fe31c79293423d504b966fae41f29..313b0f985c826dda8f5ec6f1739b27389a71a6cc 100644
--- a/third_party/WebKit/Source/core/layout/compositing/CompositingReasonFinder.h
+++ b/third_party/WebKit/Source/core/layout/compositing/CompositingReasonFinder.h
@@ -26,11 +26,14 @@ class CORE_EXPORT CompositingReasonFinder {
explicit CompositingReasonFinder(LayoutView&);
CompositingReasons potentialCompositingReasonsFromStyle(LayoutObject&) const;
- CompositingReasons directReasons(const PaintLayer*) const;
+
+ // Returns the direct reasons for compositing the given layer. If
+ // |ignoreLCDText| is true promotion will not try to preserve subpixel text
+ // rendering (i.e. partially transparent layers will be promoted).
+ CompositingReasons directReasons(const PaintLayer*, bool ignoreLCDText) const;
void updateTriggers();
- bool hasOverflowScrollTrigger() const;
bool requiresCompositingForScrollableFrame() const;
static bool requiresCompositingForAnimation(const ComputedStyle&);
static bool requiresCompositingForOpacityAnimation(const ComputedStyle&);
@@ -44,8 +47,10 @@ class CORE_EXPORT CompositingReasonFinder {
private:
bool isMainFrame() const;
- CompositingReasons nonStyleDeterminedDirectReasons(const PaintLayer*) const;
- bool requiresCompositingForScrollDependentPosition(const PaintLayer*) const;
+ CompositingReasons nonStyleDeterminedDirectReasons(const PaintLayer*,
+ bool ignoreLCDText) const;
+ bool requiresCompositingForScrollDependentPosition(const PaintLayer*,
+ bool ignoreLCDText) const;
LayoutView& m_layoutView;
CompositingTriggerFlags m_compositingTriggers;

Powered by Google App Engine
This is Rietveld 408576698