Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Unified Diff: ash/devtools/view_element.cc

Issue 2776543002: Create a unified UIElement interface for Widget, View and Window. (Closed)
Patch Set: address comments. Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ash/devtools/view_element.cc
diff --git a/ash/devtools/view_element.cc b/ash/devtools/view_element.cc
new file mode 100644
index 0000000000000000000000000000000000000000..b3105fd51a00512644c69eacefd87df6dfdd56a4
--- /dev/null
+++ b/ash/devtools/view_element.cc
@@ -0,0 +1,93 @@
+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "ash/devtools/view_element.h"
+
+#include "ash/devtools/ui_element_delegate.h"
+#include "ui/views/widget/widget.h"
+
+namespace ash {
+namespace devtools {
+
+ViewElement::ViewElement(views::View* view,
+ UIElementDelegate* ui_element_delegate,
+ UIElement* parent)
+ : UIElement(UIElementType::VIEW, ui_element_delegate, parent), view_(view) {
+ view_->AddObserver(this);
+}
+
+ViewElement::~ViewElement() {
+ view_->RemoveObserver(this);
+}
+
+void ViewElement::OnChildViewRemoved(views::View* parent, views::View* view) {
+ DCHECK_EQ(parent, view_);
+ auto iter = std::find_if(
+ children().begin(), children().end(), [view](UIElement* child) {
+ return view ==
+ UIElement::GetBackingElement<views::View, ViewElement>(child);
+ });
+ DCHECK(iter != children().end());
+ UIElement* child_element = *iter;
+ if (RemoveChild(child_element))
+ child_element->Destroy();
+}
+
+void ViewElement::OnChildViewAdded(views::View* parent, views::View* view) {
+ DCHECK_EQ(parent, view_);
+ AddChild(new ViewElement(view, delegate(), this),
+ children().empty() ? nullptr : children().back());
+}
+
+void ViewElement::OnChildViewReordered(views::View* parent, views::View* view) {
+ DCHECK_EQ(parent, view_);
+ auto iter = std::find_if(
+ children().begin(), children().end(), [view](UIElement* child) {
+ return view ==
+ UIElement::GetBackingElement<views::View, ViewElement>(child);
+ });
+ DCHECK(iter != children().end());
+ UIElement* child_element = *iter;
+ ReorderChild(child_element, parent->GetIndexOf(view));
+}
+
+void ViewElement::OnViewBoundsChanged(views::View* view) {
+ DCHECK_EQ(view_, view);
+ delegate()->OnUIElementBoundsChanged(this);
+}
+
+void ViewElement::Destroy() {
+ delete this;
+}
+
+void ViewElement::GetBounds(gfx::Rect* bounds) const {
+ *bounds = view_->bounds();
+}
+
+void ViewElement::SetBounds(const gfx::Rect& bounds) {
+ view_->SetBoundsRect(bounds);
+}
+
+void ViewElement::GetVisible(bool* visible) const {
+ *visible = view_->visible();
+}
+
+void ViewElement::SetVisible(bool visible) {
+ if (visible != view_->visible())
+ view_->SetVisible(visible);
+}
+
+std::pair<aura::Window*, gfx::Rect> ViewElement::GetNodeWindowAndBounds()
+ const {
+ return std::make_pair(view_->GetWidget()->GetNativeWindow(), view_->bounds());
+}
+
+// static
+views::View* ViewElement::From(UIElement* element) {
+ DCHECK_EQ(UIElementType::VIEW, element->type());
+ return static_cast<ViewElement*>(element)->view_;
+}
+
+} // namespace devtools
+} // namespace ash

Powered by Google App Engine
This is Rietveld 408576698