Create a unified UIElement interface for Widget, View and Window.

ash/devtools/ui_element.h

Index: ash/devtools/ui_element.h
diff --git a/ash/devtools/ui_element.h b/ash/devtools/ui_element.h
new file mode 100644
index 0000000000000000000000000000000000000000..e7b96ed8aca6826c9d827fda8d3ec40761aadfea
--- /dev/null
+++ b/ash/devtools/ui_element.h
@@ -0,0 +1,80 @@
+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef ASH_DEVTOOLS_UI_ELEMENT_H_
+#define ASH_DEVTOOLS_UI_ELEMENT_H_
+
+#include <vector>
+
+#include "ash/ash_export.h"
+#include "base/macros.h"
+#include "ui/aura/window.h"
+#include "ui/gfx/geometry/rect.h"
+#include "ui/views/view.h"
+
+namespace ash {
+
+namespace devtools {
+
+class UIElementDelegate;
+
+// UIElement type.
+enum UIElementType { WINDOW, WIDGET, VIEW };
+
+class ASH_EXPORT UIElement {
+ public:
+  int GetNodeId();
+  void SetNodeId(int node_id);
+
+  UIElement* GetParent();
+
+  UIElementDelegate* delegate();
+  UIElementType GetType();
+
+  const std::vector<UIElement*>& GetChildren() const;
+  void AddChild(std::vector<UIElement*>::iterator index, UIElement* child);
+  void PushBackChild(UIElement* child);
+  void RemoveChild(std::vector<UIElement*>::iterator index);
+  void RemoveChildFromParent();
+  UIElement* LastChild();
+
+  std::vector<UIElement*>::iterator FindChildIterator(UIElement* child);
+  std::vector<UIElement*>::iterator BeginChildIterator();
+  std::vector<UIElement*>::iterator LastChildIterator();
+  std::vector<UIElement*>::iterator ChildIndexFromParent();

[sadrul, 2017/05/03 03:02:06]

These ... seem unnecessarily complicated.

The tree-related API here should be pretty simple. For example:

  const std::vector<UIElement*>& GetChildren() const;
  void AddChild(UIElement* child, UIElement* before = nullptr);
  void RemoveChild(UIElement* child);
  void ReorderChild(UIElement* child, int new_index);

When it's necessary to find the index of a child element, the callers can do:

  const auto& children = parent->GetChildren();
  auto iter = std::find(children.begin(), children.end(), child);

[thanhph, 2017/05/03 21:58:11]

Removed, thanks!

+
+  virtual void Destroy() = 0;
+  virtual bool GetBounds(gfx::Rect* bounds) = 0;
+  virtual bool SetBounds(const gfx::Rect& bounds) = 0;
+  virtual bool GetVisible(bool* visible) = 0;
+  virtual bool SetVisible(bool visible) = 0;
+  // If element exists, return its associated native window and its bounds.
+  // Otherwise, return null and empty bounds.
+  virtual std::pair<aura::Window*, gfx::Rect> GetNodeWindowAndBounds() = 0;
+
+  template <typename BackingT, typename T>
+  static BackingT* GetBackingElement(UIElement* element) {
+    return T::From(element);
+  };
+
+ protected:
+  UIElement(const UIElementType type,
+            UIElementDelegate* ui_element_delegate,
+            UIElement* parent);
+  virtual ~UIElement();
+
+ private:
+  int node_id_;
+  std::vector<UIElement*> children_;
+  const UIElementType type_;
+  UIElement* parent_;
+  UIElementDelegate* ui_element_delegate_;
+
+  DISALLOW_COPY_AND_ASSIGN(UIElement);
+};
+
+}  // namespace devtools
+}  // namespace ash
+
+#endif  // ASH_DEVTOOLS_UI_ELEMENT_H_