Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3384)

Unified Diff: ash/devtools/ash_devtools_css_agent.cc

Issue 2776543002: Create a unified UIElement interface for Widget, View and Window. (Closed)
Patch Set: nits Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ash/devtools/ash_devtools_css_agent.cc
diff --git a/ash/devtools/ash_devtools_css_agent.cc b/ash/devtools/ash_devtools_css_agent.cc
index 84c65d7d1e0c1a31cab815248c286cc98878964e..5ccc28167d3c18ddccc41d99e83522fe42586fad 100644
--- a/ash/devtools/ash_devtools_css_agent.cc
+++ b/ash/devtools/ash_devtools_css_agent.cc
@@ -4,6 +4,7 @@
#include "ash/devtools/ash_devtools_css_agent.h"
+#include "ash/devtools/ui_element.h"
#include "base/strings/string_split.h"
#include "base/strings/string_util.h"
#include "ui/aura/window.h"
@@ -163,16 +164,8 @@ ui::devtools::protocol::Response AshDevToolsCSSAgent::setStyleTexts(
return ui::devtools::protocol::Response::OK();
}
-void AshDevToolsCSSAgent::OnWindowBoundsChanged(aura::Window* window) {
- InvalidateStyleSheet(dom_agent_->GetNodeIdFromWindow(window));
-}
-
-void AshDevToolsCSSAgent::OnWidgetBoundsChanged(views::Widget* widget) {
- InvalidateStyleSheet(dom_agent_->GetNodeIdFromWidget(widget));
-}
-
-void AshDevToolsCSSAgent::OnViewBoundsChanged(views::View* view) {
- InvalidateStyleSheet(dom_agent_->GetNodeIdFromView(view));
+void AshDevToolsCSSAgent::OnNodeBoundsChanged(int node_id) {
+ InvalidateStyleSheet(node_id);
}
std::unique_ptr<ui::devtools::protocol::CSS::CSSStyle>
@@ -192,59 +185,18 @@ void AshDevToolsCSSAgent::InvalidateStyleSheet(int node_id) {
bool AshDevToolsCSSAgent::GetPropertiesForNodeId(int node_id,
gfx::Rect* bounds,
bool* visible) {
- aura::Window* window = dom_agent_->GetWindowFromNodeId(node_id);
- if (window) {
- *bounds = window->bounds();
- *visible = window->IsVisible();
- return true;
- }
- views::Widget* widget = dom_agent_->GetWidgetFromNodeId(node_id);
- if (widget) {
- *bounds = widget->GetRestoredBounds();
- *visible = widget->IsVisible();
- return true;
- }
- views::View* view = dom_agent_->GetViewFromNodeId(node_id);
- if (view) {
- *bounds = view->bounds();
- *visible = view->visible();
+ UIElement* ui_element = dom_agent_->GetElementFromNodeId(node_id);
+ if (ui_element->GetBounds(bounds) && ui_element->GetVisible(visible))
return true;
- }
return false;
}
bool AshDevToolsCSSAgent::SetPropertiesForNodeId(int node_id,
const gfx::Rect& bounds,
bool visible) {
- aura::Window* window = dom_agent_->GetWindowFromNodeId(node_id);
- if (window) {
- window->SetBounds(bounds);
- if (visible != window->IsVisible()) {
- if (visible)
- window->Show();
- else
- window->Hide();
- }
- return true;
- }
- views::Widget* widget = dom_agent_->GetWidgetFromNodeId(node_id);
- if (widget) {
- widget->SetBounds(bounds);
- if (visible != widget->IsVisible()) {
- if (visible)
- widget->Show();
- else
- widget->Hide();
- }
+ UIElement* ui_element = dom_agent_->GetElementFromNodeId(node_id);
+ if (ui_element->SetBounds(bounds) && ui_element->SetVisible(visible))
return true;
- }
- views::View* view = dom_agent_->GetViewFromNodeId(node_id);
- if (view) {
- view->SetBoundsRect(bounds);
- if (visible != view->visible())
- view->SetVisible(visible);
- return true;
- }
return false;
}

Powered by Google App Engine
This is Rietveld 408576698