Create a unified UIElement interface for Widget, View and Window.

ash/devtools/ui_element_delegate.h

+// Copyright 2017 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef ASH_COMMON_DEVTOOLS_UI_ELEMENT_DELEGATE_H_
+#define ASH_COMMON_DEVTOOLS_UI_ELEMENT_DELEGATE_H_

[sadrul, 2017/05/01 16:22:27]

Make sure to update these

[thanhph, 2017/05/03 21:58:10]

Done.

+
+#include <vector>
+
+#include "ash/ash_export.h"
+#include "base/macros.h"
+
+namespace ash {
+namespace devtools {
+
+class UIElement;
+
+class ASH_EXPORT UIElementDelegate {
+ public:
+  UIElementDelegate(){};
+  ~UIElementDelegate(){};
+  virtual void OnUIElementAdded(
+      int node_id,
+      UIElement* child_ui_element,
+      std::vector<UIElement*>::iterator prev_siblings);

[sadrul, 2017/05/01 16:22:27]

This should be:

  virtual void OnUIElementAdded(UIElement* parent,
                                UIElement* child,
                                int index) = 0;
or
  virtual void OnUIElementAdded(UIElement* parent,
                                UIElement* child,
                                UIElement* prev_sibling) = 0;

[thanhph, 2017/05/03 21:58:10]

Done.

+  virtual void RemoveNodeIdMap(int node_id);
+  virtual bool OnUIElementRemoved(int node_id);
+  virtual void OnUIElementBoundsChanged(int node_id);

[sadrul, 2017/05/01 16:22:27]

Instead of getting node-id, can these callbacks get the UIElement* instead?

[thanhph, 2017/05/03 21:58:10]

Done.

+
+  DISALLOW_COPY_AND_ASSIGN(UIElementDelegate);
+};
+
+}  // namespace devtools
+}  // namespace ash
+
+#endif  // ASH_COMMON_DEVTOOLS_UI_ELEMENT_DELEGATE_H_