Plumbing devtools agent host id and request id between processes

Plumbing devtools agent host id and request id between processes
required by https://codereview.chromium.org/2739323003/

This data will let us:
1. Emit DevTools Network domain events from the browser with constant
RequestIds for both regular renderer initiated fetches and PlzNavigate 
browser side navigations.
2. Let a net::URLRequestInterceptor introduced by the subsequent patch
 figure out which requests correspond to an inspected page.
3. Get rid of the X-DevTools-Request-Id and
X-DevTools-Emulate-Network-Conditions-Client-Id headers.

BUG=702384, 546953
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_iso;master.tryserver.chromium.linux:linux_site_isolation

[alex clarke (OOO till 29th), 2017-03-24 10:46:48]

Description was changed from

==========
For browserside navigations use a browser generated inspector request id

BUG=
==========

to

==========
For browserside navigations use a browser generated inspector request id

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

[alex clarke (OOO till 29th), 2017-03-24 10:47:07]

The CQ bit was checked by alexclarke@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-24 10:47:34]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-24 11:59:20]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-24 11:59:20]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[alex clarke (OOO till 29th), 2017-03-24 13:30:04]

The CQ bit was checked by alexclarke@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-24 13:30:14]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[alex clarke (OOO till 29th), 2017-03-24 14:29:37]

The CQ bit was checked by alexclarke@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-24 14:29:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[alex clarke (OOO till 29th), 2017-03-24 15:36:52]

The CQ bit was checked by alexclarke@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-24 15:37:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[alex clarke (OOO till 29th), 2017-03-24 15:48:22]

The CQ bit was checked by alexclarke@chromium.org to run a CQ dry run

[alex clarke (OOO till 29th), 2017-03-24 15:48:37]

alexclarke@chromium.org changed reviewers:
+ skyostil@chromium.org

[commit-bot: I haz the power, 2017-03-24 15:48:55]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-24 15:59:06]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-24 15:59:07]

Dry run: Try jobs failed on following builders:
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[alex clarke (OOO till 29th), 2017-03-24 16:03:10]

The CQ bit was checked by alexclarke@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-24 16:04:31]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-24 16:16:34]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-24 16:16:35]

Dry run: Try jobs failed on following builders:
  mac_chromium_compile_dbg_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...)

[alex clarke (OOO till 29th), 2017-03-24 16:25:16]

The CQ bit was checked by alexclarke@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-24 16:25:59]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-24 16:37:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-24 16:37:10]

Dry run: Try jobs failed on following builders:
  cast_shell_android on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/cast_shell_a...)
  linux_chromium_tsan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[pfeldman, 2017-03-24 17:12:50]

On 2017/03/24 15:48:38, alex clarke wrote:

That's like pure technical debt right here... Can we try minimizing it? Also,
how is main resource redirect handled, are we reporting those at all?

[dgozman, 2017-03-24 17:28:27]

On 2017/03/24 17:12:50, pfeldman wrote:
> On 2017/03/24 15:48:38, alex clarke wrote:
> 
> That's like pure technical debt right here... Can we try minimizing it? Also,
> how is main resource redirect handled, are we reporting those at all?

IIRC, clamy@ from PlzNavigate team plumbed it through, although I didn't look
into details. We have a layout test which covers it.

[pfeldman, 2017-03-24 19:11:19]

Discussed it with dgozman@, here is the summary:
- mapping ids is not nice
- intercepting based on the headers is also not nice.

Questions / proposal:
- could we generate browser_request_id_ next to nav_entry_id_ for
browser-initiated navigations and use it _instead_ of createUniqueIdentifier in
Blink? I.e. your devtools is made official for Blink. We would create browser
and renderer partitions so that ids did not clash. That eliminates the mapping
part.
- could we discuss the platform and content-level interception? I.e. hack
ResourceFetcher to do what we need in Blink + make PlzNavigate respect
interceptor on the browser level.

By the PlzNavigate modulus, it does not sound scary at all. So maybe we should
try that out? Wdyt? Should we meet over VC?

[alex clarke (OOO till 29th), 2017-03-27 08:16:14]

The CQ bit was checked by alexclarke@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-27 08:16:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-27 08:25:41]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-27 08:25:41]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[alex clarke (OOO till 29th), 2017-03-27 08:34:59]

Patchset #8 (id:130001) has been deleted

[alex clarke (OOO till 29th), 2017-03-27 08:36:02]

The CQ bit was checked by alexclarke@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-27 08:36:23]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-27 09:32:53]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-27 09:32:54]

Dry run: Try jobs failed on following builders:
  linux_site_isolation on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_site_isol...)
  win_chromium_x64_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[alex clarke (OOO till 29th), 2017-03-28 10:52:52]

The CQ bit was checked by alexclarke@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-28 10:53:05]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-28 11:52:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-28 11:52:14]

Dry run: Try jobs failed on following builders:
  cast_shell_linux on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linu...)

[alex clarke (OOO till 29th), 2017-03-29 14:59:52]

Description was changed from

==========
For browserside navigations use a browser generated inspector request id

BUG=
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Plumbing devtools agent host id and request id between processes

This data will let us:
1. Emit DevTools Network domain events from the browser and the renderer with
consistent RequestIds.
2. Let a net::URLRequestInterceptor introduced by the subsequent patch figure
out which requests correspond to an inspected page.
3. Get rid of the X-DevTools-Request-Id and
X-DevTools-Emulate-Network-Conditions-Client-Id headers.


BUG=702384, 546953
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_iso
==========

[alex clarke (OOO till 29th), 2017-03-29 15:00:42]

Description was changed from

==========
Plumbing devtools agent host id and request id between processes

This data will let us:
1. Emit DevTools Network domain events from the browser and the renderer with
consistent RequestIds.
2. Let a net::URLRequestInterceptor introduced by the subsequent patch figure
out which requests correspond to an inspected page.
3. Get rid of the X-DevTools-Request-Id and
X-DevTools-Emulate-Network-Conditions-Client-Id headers.


BUG=702384, 546953
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_iso
==========

to

==========
Plumbing devtools agent host id and request id between processes

This data will let us:
1. Emit DevTools Network domain events from the browser and the renderer with
consistent RequestIds.
2. Let a net::URLRequestInterceptor introduced by the subsequent patch figure
out which requests correspond to an inspected page.
3. Get rid of the X-DevTools-Request-Id and
X-DevTools-Emulate-Network-Conditions-Client-Id headers.


BUG=702384, 546953
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_iso;master.tryserver.chromium.linux:linux_site_isolation
==========

[alex clarke (OOO till 29th), 2017-03-29 15:00:46]

Description was changed from

==========
Plumbing devtools agent host id and request id between processes

This data will let us:
1. Emit DevTools Network domain events from the browser and the renderer with
consistent RequestIds.
2. Let a net::URLRequestInterceptor introduced by the subsequent patch figure
out which requests correspond to an inspected page.
3. Get rid of the X-DevTools-Request-Id and
X-DevTools-Emulate-Network-Conditions-Client-Id headers.


BUG=702384, 546953
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_iso;master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Plumbing devtools agent host id and request id between processes

This data will let us:
1. Emit DevTools Network domain events from the browser and the 
renderer with consistent RequestIds.
2. Let a net::URLRequestInterceptor introduced by the subsequent patch
 figure out which requests correspond to an inspected page.
3. Get rid of the X-DevTools-Request-Id and
X-DevTools-Emulate-Network-Conditions-Client-Id headers.


BUG=702384, 546953
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_iso
==========

[alex clarke (OOO till 29th), 2017-03-29 15:00:53]

The CQ bit was checked by alexclarke@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-29 15:01:29]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[alex clarke (OOO till 29th), 2017-03-29 15:02:44]

Description was changed from

==========
Plumbing devtools agent host id and request id between processes

This data will let us:
1. Emit DevTools Network domain events from the browser and the 
renderer with consistent RequestIds.
2. Let a net::URLRequestInterceptor introduced by the subsequent patch
 figure out which requests correspond to an inspected page.
3. Get rid of the X-DevTools-Request-Id and
X-DevTools-Emulate-Network-Conditions-Client-Id headers.


BUG=702384, 546953
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_iso
==========

to

==========
Plumbing devtools agent host id and request id between processes

This data will let us:
1. Emit DevTools Network domain events from the browser with constant
RequestIds for both regular renderer initiated fetches and PlzNavigate browser
side navigations.
2. Let a net::URLRequestInterceptor introduced by the subsequent patch
 figure out which requests correspond to an inspected page.
3. Get rid of the X-DevTools-Request-Id and
X-DevTools-Emulate-Network-Conditions-Client-Id headers.

BUG=702384, 546953
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_iso
==========

[alex clarke (OOO till 29th), 2017-03-29 15:02:52]

Description was changed from

==========
Plumbing devtools agent host id and request id between processes

This data will let us:
1. Emit DevTools Network domain events from the browser with constant
RequestIds for both regular renderer initiated fetches and PlzNavigate browser
side navigations.
2. Let a net::URLRequestInterceptor introduced by the subsequent patch
 figure out which requests correspond to an inspected page.
3. Get rid of the X-DevTools-Request-Id and
X-DevTools-Emulate-Network-Conditions-Client-Id headers.

BUG=702384, 546953
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_iso
==========

to

==========
Plumbing devtools agent host id and request id between processes

This data will let us:
1. Emit DevTools Network domain events from the browser with constant
RequestIds for both regular renderer initiated fetches and PlzNavigate 
browser side navigations.
2. Let a net::URLRequestInterceptor introduced by the subsequent patch
 figure out which requests correspond to an inspected page.
3. Get rid of the X-DevTools-Request-Id and
X-DevTools-Emulate-Network-Conditions-Client-Id headers.

BUG=702384, 546953
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_iso
==========

[commit-bot: I haz the power, 2017-03-29 15:04:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-29 15:04:13]

Dry run: Try jobs failed on following builders:
  linux_site_iso on master.tryserver.chromium.linux (JOB_FAILED, build hasn't
started yet, builder probably lacks capacity)

[alex clarke (OOO till 29th), 2017-03-29 15:06:08]

On 2017/03/24 19:11:19, pfeldman wrote:
> Discussed it with dgozman@, here is the summary:
> - mapping ids is not nice
> - intercepting based on the headers is also not nice.
> 
> Questions / proposal:
> - could we generate browser_request_id_ next to nav_entry_id_ for
> browser-initiated navigations and use it _instead_ of createUniqueIdentifier
in
> Blink? I.e. your devtools is made official for Blink. We would create browser
> and renderer partitions so that ids did not clash. That eliminates the mapping
> part.
> - could we discuss the platform and content-level interception? I.e. hack
> ResourceFetcher to do what we need in Blink + make PlzNavigate respect
> interceptor on the browser level.
> 
> By the PlzNavigate modulus, it does not sound scary at all. So maybe we should
> try that out? Wdyt? Should we meet over VC?

After meeting with Dmitry I've come up with a revised patch. This has all the
plumbing needed to avoid the headers.  It lets the browser generate identifiers
which blink will use (we no longer need to map ids).  WDYT?

[alex clarke (OOO till 29th), 2017-03-29 15:06:25]

alexclarke@chromium.org changed reviewers:
+ dgozman@chromium.org, pfeldman@chromium.org

[alex clarke (OOO till 29th), 2017-03-29 15:06:47]

PTAL

[alex clarke (OOO till 29th), 2017-03-29 15:20:46]

Description was changed from

==========
Plumbing devtools agent host id and request id between processes

This data will let us:
1. Emit DevTools Network domain events from the browser with constant
RequestIds for both regular renderer initiated fetches and PlzNavigate 
browser side navigations.
2. Let a net::URLRequestInterceptor introduced by the subsequent patch
 figure out which requests correspond to an inspected page.
3. Get rid of the X-DevTools-Request-Id and
X-DevTools-Emulate-Network-Conditions-Client-Id headers.

BUG=702384, 546953
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_iso
==========

to

==========
Plumbing devtools agent host id and request id between processes
required by https://codereview.chromium.org/2739323003/

This data will let us:
1. Emit DevTools Network domain events from the browser with constant
RequestIds for both regular renderer initiated fetches and PlzNavigate 
browser side navigations.
2. Let a net::URLRequestInterceptor introduced by the subsequent patch
 figure out which requests correspond to an inspected page.
3. Get rid of the X-DevTools-Request-Id and
X-DevTools-Emulate-Network-Conditions-Client-Id headers.

BUG=702384, 546953
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_iso
==========

[Sami, 2017-03-29 16:41:42]

Lg to me but I'll let others approve :)

https://codereview.chromium.org/2776523005/diff/210001/content/browser/frame_...
File content/browser/frame_host/navigation_request_info.h (right):

https://codereview.chromium.org/2776523005/diff/210001/content/browser/frame_...
content/browser/frame_host/navigation_request_info.h:36: unsigned int
devtools_request_id);
nit: We generally don't use unsigned types (Looks like some of the existing
types are unsigned but let's not add new ones if we can avoid it.)
(https://chromium.googlesource.com/chromium/src/+/master/styleguide/c++/c++.md...)

https://codereview.chromium.org/2776523005/diff/210001/content/browser/loader...
File content/browser/loader/resource_dispatcher_host_impl.cc (right):

https://codereview.chromium.org/2776523005/diff/210001/content/browser/loader...
content/browser/loader/resource_dispatcher_host_impl.cc:2063: // know the
browser PID yet so just specify zero.
Do you mean the renderer pid?

https://codereview.chromium.org/2776523005/diff/210001/content/child/web_url_...
File content/child/web_url_loader_impl.cc (right):

https://codereview.chromium.org/2776523005/diff/210001/content/child/web_url_...
content/child/web_url_loader_impl.cc:606:
request.devToolsAgentHostId().latin1();
utf8() instead of latin1()?

https://codereview.chromium.org/2776523005/diff/210001/content/child/web_url_...
content/child/web_url_loader_impl.cc:607: resource_request->devtools_request_id
= request.devToolsRequestId().latin1();
Ditto.

https://codereview.chromium.org/2776523005/diff/210001/content/common/navigat...
File content/common/navigation_params.h (right):

https://codereview.chromium.org/2776523005/diff/210001/content/common/navigat...
content/common/navigation_params.h:322: // navigations this will be zero.
Ditto about unsigned.

https://codereview.chromium.org/2776523005/diff/210001/content/common/net/url...
File content/common/net/url_request_devtools_user_data.h (right):

https://codereview.chromium.org/2776523005/diff/210001/content/common/net/url...
content/common/net/url_request_devtools_user_data.h:1: // Copyright (c) 2017 The
Chromium Authors. All rights reserved.
nit: Use the new-style license template.

[alex clarke (OOO till 29th), 2017-03-30 09:22:52]

Description was changed from

==========
Plumbing devtools agent host id and request id between processes
required by https://codereview.chromium.org/2739323003/

This data will let us:
1. Emit DevTools Network domain events from the browser with constant
RequestIds for both regular renderer initiated fetches and PlzNavigate 
browser side navigations.
2. Let a net::URLRequestInterceptor introduced by the subsequent patch
 figure out which requests correspond to an inspected page.
3. Get rid of the X-DevTools-Request-Id and
X-DevTools-Emulate-Network-Conditions-Client-Id headers.

BUG=702384, 546953
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_iso
==========

to

==========
Plumbing devtools agent host id and request id between processes
required by https://codereview.chromium.org/2739323003/

This data will let us:
1. Emit DevTools Network domain events from the browser with constant
RequestIds for both regular renderer initiated fetches and PlzNavigate 
browser side navigations.
2. Let a net::URLRequestInterceptor introduced by the subsequent patch
 figure out which requests correspond to an inspected page.
3. Get rid of the X-DevTools-Request-Id and
X-DevTools-Emulate-Network-Conditions-Client-Id headers.

BUG=702384, 546953
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_iso;master.tryserver.chromium.linux:linux_site_isolation
==========

[alex clarke (OOO till 29th), 2017-03-30 09:23:24]

The CQ bit was checked by alexclarke@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-03-30 09:23:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-30 09:24:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-30 09:24:52]

Dry run: Try jobs failed on following builders:
  linux_site_iso on master.tryserver.chromium.linux (JOB_FAILED, build hasn't
started yet, builder probably lacks capacity)

[alex clarke (OOO till 29th), 2017-03-30 16:56:50]

The CQ bit was checked by alexclarke@chromium.org to run a CQ dry run

[alex clarke (OOO till 29th), 2017-03-30 16:56:55]

https://codereview.chromium.org/2776523005/diff/210001/content/browser/frame_...
File content/browser/frame_host/navigation_request_info.h (right):

https://codereview.chromium.org/2776523005/diff/210001/content/browser/frame_...
content/browser/frame_host/navigation_request_info.h:36: unsigned int
devtools_request_id);
On 2017/03/29 16:41:42, Sami wrote:
> nit: We generally don't use unsigned types (Looks like some of the existing
> types are unsigned but let's not add new ones if we can avoid it.)
>
(https://chromium.googlesource.com/chromium/src/+/master/styleguide/c++/c++.md...)

Done.

https://codereview.chromium.org/2776523005/diff/210001/content/browser/loader...
File content/browser/loader/resource_dispatcher_host_impl.cc (right):

https://codereview.chromium.org/2776523005/diff/210001/content/browser/loader...
content/browser/loader/resource_dispatcher_host_impl.cc:2063: // know the
browser PID yet so just specify zero.
On 2017/03/29 16:41:42, Sami wrote:
> Do you mean the renderer pid?

Done.

https://codereview.chromium.org/2776523005/diff/210001/content/child/web_url_...
File content/child/web_url_loader_impl.cc (right):

https://codereview.chromium.org/2776523005/diff/210001/content/child/web_url_...
content/child/web_url_loader_impl.cc:606:
request.devToolsAgentHostId().latin1();
On 2017/03/29 16:41:42, Sami wrote:
> utf8() instead of latin1()?

Done.

https://codereview.chromium.org/2776523005/diff/210001/content/child/web_url_...
content/child/web_url_loader_impl.cc:607: resource_request->devtools_request_id
= request.devToolsRequestId().latin1();
On 2017/03/29 16:41:42, Sami wrote:
> Ditto.

Done.

https://codereview.chromium.org/2776523005/diff/210001/content/common/navigat...
File content/common/navigation_params.h (right):

https://codereview.chromium.org/2776523005/diff/210001/content/common/navigat...
content/common/navigation_params.h:322: // navigations this will be zero.
On 2017/03/29 16:41:42, Sami wrote:
> Ditto about unsigned.

Done.

https://codereview.chromium.org/2776523005/diff/210001/content/common/net/url...
File content/common/net/url_request_devtools_user_data.h (right):

https://codereview.chromium.org/2776523005/diff/210001/content/common/net/url...
content/common/net/url_request_devtools_user_data.h:1: // Copyright (c) 2017 The
Chromium Authors. All rights reserved.
On 2017/03/29 16:41:42, Sami wrote:
> nit: Use the new-style license template.

Not 100% sure but is this what you mean?

[commit-bot: I haz the power, 2017-03-30 16:57:09]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-03-30 16:59:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-03-30 16:59:43]

Dry run: Try jobs failed on following builders:
  linux_site_iso on master.tryserver.chromium.linux (JOB_FAILED, build hasn't
started yet, builder probably lacks capacity)

[alex clarke (OOO till 29th), 2017-04-10 14:10:46]

The CQ bit was checked by alexclarke@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2017-04-10 14:11:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2017-04-10 14:12:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2017-04-10 14:12:06]

Dry run: Try jobs failed on following builders:
  linux_site_iso on master.tryserver.chromium.linux (JOB_FAILED, build hasn't
started yet, builder probably lacks capacity)

[alex clarke (OOO till 29th), 2017-04-12 08:35:47]

Description was changed from

==========
Plumbing devtools agent host id and request id between processes
required by https://codereview.chromium.org/2739323003/

This data will let us:
1. Emit DevTools Network domain events from the browser with constant
RequestIds for both regular renderer initiated fetches and PlzNavigate 
browser side navigations.
2. Let a net::URLRequestInterceptor introduced by the subsequent patch
 figure out which requests correspond to an inspected page.
3. Get rid of the X-DevTools-Request-Id and
X-DevTools-Emulate-Network-Conditions-Client-Id headers.

BUG=702384, 546953
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_iso;master.tryserver.chromium.linux:linux_site_isolation
==========

to

==========
Plumbing devtools agent host id and request id between processes
required by https://codereview.chromium.org/2739323003/

This data will let us:
1. Emit DevTools Network domain events from the browser with constant
RequestIds for both regular renderer initiated fetches and PlzNavigate 
browser side navigations.
2. Let a net::URLRequestInterceptor introduced by the subsequent patch
 figure out which requests correspond to an inspected page.
3. Get rid of the X-DevTools-Request-Id and
X-DevTools-Emulate-Network-Conditions-Client-Id headers.

BUG=702384, 546953
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_site_iso;master.tryserver.chromium.linux:linux_site_isolation
==========