Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1713)

Unified Diff: chrome/browser/ui/webui/supervised_user_internals_message_handler.h

Issue 2776493005: Convert SupervisedUserResourceThrottle to a NavigationThrottle. (Closed)
Patch Set: Response to comments Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/webui/supervised_user_internals_message_handler.h
diff --git a/chrome/browser/ui/webui/supervised_user_internals_message_handler.h b/chrome/browser/ui/webui/supervised_user_internals_message_handler.h
index 161b5d0a8eff50da7e136ab227ded157960c7578..aa6c3d9b680454b5b0feb77db30426dbae1c592f 100644
--- a/chrome/browser/ui/webui/supervised_user_internals_message_handler.h
+++ b/chrome/browser/ui/webui/supervised_user_internals_message_handler.h
@@ -8,6 +8,7 @@
#include "base/callback_list.h"
#include "base/macros.h"
#include "base/memory/weak_ptr.h"
+#include "base/scoped_observer.h"
#include "chrome/browser/supervised_user/supervised_user_service_observer.h"
#include "chrome/browser/supervised_user/supervised_user_url_filter.h"
#include "components/supervised_user_error_page/supervised_user_error_page.h"
@@ -22,14 +23,13 @@ class SupervisedUserService;
// The implementation for the chrome://supervised-user-internals page.
class SupervisedUserInternalsMessageHandler
: public content::WebUIMessageHandler,
- public SupervisedUserServiceObserver {
+ public SupervisedUserServiceObserver,
+ public SupervisedUserURLFilter::Observer {
public:
SupervisedUserInternalsMessageHandler();
~SupervisedUserInternalsMessageHandler() override;
private:
- class IOThreadHelper;
-
// content::WebUIMessageHandler:
void RegisterMessages() override;
@@ -51,16 +51,19 @@ class SupervisedUserInternalsMessageHandler
supervised_user_error_page::FilteringBehaviorReason reason,
bool uncertain);
+ // SupervisedUserURLFilter::Observer:
+ void OnSiteListUpdated() override;
void OnURLChecked(const GURL& url,
SupervisedUserURLFilter::FilteringBehavior behavior,
supervised_user_error_page::FilteringBehaviorReason reason,
- bool uncertain);
+ bool uncertain) override;
std::unique_ptr<
base::CallbackList<void(const base::DictionaryValue*)>::Subscription>
user_settings_subscription_;
- scoped_refptr<IOThreadHelper> io_thread_helper_;
+ ScopedObserver<SupervisedUserURLFilter, SupervisedUserURLFilter::Observer>
+ scoped_observer_;
base::WeakPtrFactory<SupervisedUserInternalsMessageHandler> weak_factory_;

Powered by Google App Engine
This is Rietveld 408576698