Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4276)

Unified Diff: chrome/browser/supervised_user/supervised_user_browsertest.cc

Issue 2776493005: Convert SupervisedUserResourceThrottle to a NavigationThrottle. (Closed)
Patch Set: Response to comments Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/supervised_user/supervised_user_browsertest.cc
diff --git a/chrome/browser/supervised_user/supervised_user_browsertest.cc b/chrome/browser/supervised_user/supervised_user_browsertest.cc
index 6f85ea25c634366d0149e7a3b96fa1ab870733ed..8166ea504d258b5834f436b6ed64fa7650672822 100644
--- a/chrome/browser/supervised_user/supervised_user_browsertest.cc
+++ b/chrome/browser/supervised_user/supervised_user_browsertest.cc
@@ -238,8 +238,8 @@ IN_PROC_BROWSER_TEST_F(SupervisedUserBlockModeTest,
HistoryVisitRecorded) {
GURL allowed_url("http://www.example.com/simple.html");
- scoped_refptr<SupervisedUserURLFilter> filter =
- supervised_user_service_->GetURLFilterForUIThread();
+ const SupervisedUserURLFilter* filter =
+ supervised_user_service_->GetURLFilter();
// Set the host as allowed.
std::unique_ptr<base::DictionaryValue> dict(new base::DictionaryValue);
@@ -343,8 +343,8 @@ IN_PROC_BROWSER_TEST_F(SupervisedUserTest, GoBackOnDontProceed) {
supervised_user_settings_service->SetLocalSetting(
supervised_users::kContentPackManualBehaviorHosts, std::move(dict));
- scoped_refptr<SupervisedUserURLFilter> filter =
- supervised_user_service_->GetURLFilterForUIThread();
+ const SupervisedUserURLFilter* filter =
+ supervised_user_service_->GetURLFilter();
ASSERT_EQ(SupervisedUserURLFilter::BLOCK,
filter->GetFilteringBehaviorForURL(test_url));
@@ -384,8 +384,8 @@ IN_PROC_BROWSER_TEST_F(SupervisedUserTest, BlockThenUnblock) {
supervised_user_settings_service->SetLocalSetting(
supervised_users::kContentPackManualBehaviorHosts, std::move(dict));
- scoped_refptr<SupervisedUserURLFilter> filter =
- supervised_user_service_->GetURLFilterForUIThread();
+ const SupervisedUserURLFilter* filter =
+ supervised_user_service_->GetURLFilter();
ASSERT_EQ(SupervisedUserURLFilter::BLOCK,
filter->GetFilteringBehaviorForURL(test_url));
@@ -426,8 +426,8 @@ IN_PROC_BROWSER_TEST_F(SupervisedUserBlockModeTest, Unblock) {
supervised_user_settings_service->SetLocalSetting(
supervised_users::kContentPackManualBehaviorHosts, std::move(dict));
- scoped_refptr<SupervisedUserURLFilter> filter =
- supervised_user_service_->GetURLFilterForUIThread();
+ const SupervisedUserURLFilter* filter =
+ supervised_user_service_->GetURLFilter();
EXPECT_EQ(SupervisedUserURLFilter::ALLOW,
filter->GetFilteringBehaviorForURL(test_url.GetWithEmptyPath()));

Powered by Google App Engine
This is Rietveld 408576698