Convert SupervisedUserResourceThrottle to a NavigationThrottle.

chrome/browser/supervised_user/supervised_user_service.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_SUPERVISED_USER_SUPERVISED_USER_SERVICE_H_
 #define CHROME_BROWSER_SUPERVISED_USER_SUPERVISED_USER_SERVICE_H_
 
 #include <stddef.h>
 
 #include <map>
@@ skipping 88 matching lines @@
 
   ~SupervisedUserService() override;
 
   static void RegisterProfilePrefs(user_prefs::PrefRegistrySyncable* registry);
 
   // Initializes this object.
   void Init();
 
   void SetDelegate(Delegate* delegate);
 
-  // Returns the URL filter for the IO thread, for filtering network requests
-  // (in SupervisedUserResourceThrottle).
-  scoped_refptr<const SupervisedUserURLFilter> GetURLFilterForIOThread();
-
-  // Returns the URL filter for the UI thread, for filtering navigations and
-  // classifying sites in the history view.
-  SupervisedUserURLFilter* GetURLFilterForUIThread();
+  // Returns the URL filter for filtering navigations and classifying sites in
+  // the history view. Both this method and the returned filter may only be used
+  // on the UI thread.
+  SupervisedUserURLFilter* GetURLFilter();
 
   // Returns the whitelist service.
   SupervisedUserWhitelistService* GetWhitelistService();
 
   const std::vector<scoped_refptr<SupervisedUserSiteList>>& whitelists() const {
     return whitelists_;
   }
 
   // Whether the user can request to get access to blocked URLs or to new
   // extensions.
@@ skipping 106 matching lines @@
   FRIEND_TEST_ALL_PREFIXES(
       SupervisedUserServiceExtensionTest,
       ExtensionManagementPolicyProviderWithoutSUInitiatedInstalls);
   FRIEND_TEST_ALL_PREFIXES(
       SupervisedUserServiceExtensionTest,
       ExtensionManagementPolicyProviderWithSUInitiatedInstalls);
 
   using CreatePermissionRequestCallback =
       base::Callback<void(PermissionRequestCreator*, const SuccessCallback&)>;
 
-  // A bridge from the UI thread to the SupervisedUserURLFilters, one of which
-  // lives on the IO thread. This class mediates access to them and makes sure
-  // they are kept in sync.
-  class URLFilterContext {
-   public:
-    URLFilterContext();
-    ~URLFilterContext();
-
-    SupervisedUserURLFilter* ui_url_filter() const;
-    SupervisedUserURLFilter* io_url_filter() const;
-
-    void SetDefaultFilteringBehavior(
-        SupervisedUserURLFilter::FilteringBehavior behavior);
-    void LoadWhitelists(
-        const std::vector<scoped_refptr<SupervisedUserSiteList>>& site_lists);
-    // TODO(treib): Make SupervisedUserBlacklist refcounted, so the IO thread
-    // will retain a reference to the blacklist.
-    void SetBlacklist(const SupervisedUserBlacklist* blacklist);
-    bool HasBlacklist() const;
-    void SetManualHosts(std::unique_ptr<std::map<std::string, bool>> host_map);
-    void SetManualURLs(std::unique_ptr<std::map<GURL, bool>> url_map);
-
-    void InitAsyncURLChecker(
-        const scoped_refptr<net::URLRequestContextGetter>& context);
-    bool HasAsyncURLChecker() const;
-    void ClearAsyncURLChecker();
-
-    void Clear();
-
-   private:
-    void OnBlacklistLoaded(const base::Closure& callback);
-
-    // SupervisedUserURLFilter is refcounted because the IO thread filter is
-    // used both by ProfileImplIOData and OffTheRecordProfileIOData (to filter
-    // network requests), so they both keep a reference to it.
-    // Clients should not keep references to the UI thread filter, however
-    // (the filter will live as long as the profile lives, and afterwards it
-    // should not be used anymore either).
-    scoped_refptr<SupervisedUserURLFilter> ui_url_filter_;
-    scoped_refptr<SupervisedUserURLFilter> io_url_filter_;
-
-    DISALLOW_COPY_AND_ASSIGN(URLFilterContext);
-  };
-
   // Use |SupervisedUserServiceFactory::GetForProfile(..)| to get
   // an instance of this service.
   explicit SupervisedUserService(Profile* profile);
 
   void SetActive(bool active);
 
 #if !defined(OS_ANDROID)
   void OnCustodianProfileDownloaded(const base::string16& full_name);
 
   void OnSupervisedUserRegistered(const AuthErrorCallback& callback,
@@ skipping 135 matching lines @@
   bool is_profile_active_;
 
   std::vector<NavigationBlockedCallback> navigation_blocked_callbacks_;
 
   // True only when |Init()| method has been called.
   bool did_init_;
 
   // True only when |Shutdown()| method has been called.
   bool did_shutdown_;
 
-  URLFilterContext url_filter_context_;
+  SupervisedUserURLFilter url_filter_;
 
   // Stores a map from extension_id -> approved version by the custodian.
   // It is only relevant for SU-initiated installs.
   std::map<std::string, base::Version> approved_extensions_map_;
 
   enum class BlacklistLoadState {
     NOT_LOADED,
     LOAD_STARTED,
     LOADED
   } blacklist_state_;
@@ skipping 19 matching lines @@
 
   base::ObserverList<SupervisedUserServiceObserver> observer_list_;
 
   // Prevents Sync from running until configuration is complete.
   std::unique_ptr<syncer::SyncSetupInProgressHandle> sync_blocker_;
 
   base::WeakPtrFactory<SupervisedUserService> weak_ptr_factory_;
 };
 
 #endif  // CHROME_BROWSER_SUPERVISED_USER_SUPERVISED_USER_SERVICE_H_