Convert SupervisedUserResourceThrottle to a NavigationThrottle.

chrome/browser/supervised_user/supervised_user_service_factory.h

 // Copyright 2014 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_SUPERVISED_USER_SUPERVISED_USER_SERVICE_FACTORY_H_
 #define CHROME_BROWSER_SUPERVISED_USER_SUPERVISED_USER_SERVICE_FACTORY_H_
 
 #include "base/memory/singleton.h"
 #include "chrome/browser/supervised_user/supervised_users.h"
 #include "components/keyed_service/content/browser_context_keyed_service_factory.h"
 
+namespace content {
+class BrowserContext;
+}
+
 class Profile;
 class SupervisedUserService;
 
 class SupervisedUserServiceFactory : public BrowserContextKeyedServiceFactory {
  public:
-  static SupervisedUserService* GetForProfile(Profile* profile);
+  static SupervisedUserService* GetForProfile(
+      content::BrowserContext* browser_context);

[Marc Treib, 2017/03/28 10:22:58]

Is this change actually required? If so, the method should probably be renamed
to GetForBrowserContext, but updating all callers won't be fun... maybe just
have both?

[mmenke, 2017/03/28 17:55:05]

It's not really needed, I just was horrified by:

SupervisedUserServiceFactory::GetForProfile(navigation_handle->GetWebContents()->GetBrowserContext())->GetURLFilter()

And thought throwing in a Profile::FromBrowserContext in there made the line
even worse, particularly as SupervisedUserServiceFactory::GetForProfile actually
uses a method that just needs a BrowserContext, not a profile.  I've gone ahead
and added Profile::FromBrowserContext to the aforementioned horrifying line
(Prefer that to adding a method to SupervisedUserServiceFactory).

 
   static SupervisedUserServiceFactory* GetInstance();
 
   // Used to create instances for testing.
   static KeyedService* BuildInstanceFor(Profile* profile);
 
  private:
   friend struct base::DefaultSingletonTraits<SupervisedUserServiceFactory>;
 
   SupervisedUserServiceFactory();
   ~SupervisedUserServiceFactory() override;
 
   // BrowserContextKeyedServiceFactory:
   content::BrowserContext* GetBrowserContextToUse(
       content::BrowserContext* context) const override;
   KeyedService* BuildServiceInstanceFor(
       content::BrowserContext* profile) const override;
 };
 
 #endif  // CHROME_BROWSER_SUPERVISED_USER_SUPERVISED_USER_SERVICE_FACTORY_H_