Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(729)

Issue 2776383002: Use InterceptorDataBuilderImpl and BackendUsageBuilderImpl for kernel/closed_world_test (Closed)

Created:
3 years, 8 months ago by Johnni Winther
Modified:
3 years, 8 months ago
Reviewers:
Emily Fortuna
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Use InterceptorDataBuilderImpl and BackendUsageBuilderImpl for kernel/closed_world_test A step towards computing closed world based on kernel. R=efortuna@google.com Committed: https://github.com/dart-lang/sdk/commit/6f48182a04605d90d40a54330793f43f56d1ecfa

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+43 lines, -36 lines) Patch
M pkg/compiler/lib/src/js_backend/backend.dart View 2 chunks +2 lines, -7 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/backend_usage.dart View 7 chunks +34 lines, -25 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/interceptor_data.dart View 2 chunks +1 line, -2 lines 0 comments Download
M tests/compiler/dart2js/kernel/closed_world_test.dart View 2 chunks +6 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Johnni Winther
3 years, 8 months ago (2017-03-28 14:49:30 UTC) #2
Emily Fortuna
lgtm
3 years, 8 months ago (2017-03-28 18:34:37 UTC) #3
Johnni Winther
3 years, 8 months ago (2017-03-29 09:32:47 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
6f48182a04605d90d40a54330793f43f56d1ecfa (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698