Initial steps into streaming the kernel flowgraph

runtime/vm/kernel_binary_flowgraph.h

+// Copyright (c) 2017, the Dart project authors.  Please see the AUTHORS file
+// for details. All rights reserved. Use of this source code is governed by a
+// BSD-style license that can be found in the LICENSE file.
+
+#ifndef RUNTIME_VM_KERNEL_BINARY_FLOWGRAPH_H_
+#define RUNTIME_VM_KERNEL_BINARY_FLOWGRAPH_H_
+
+#if !defined(DART_PRECOMPILED_RUNTIME)
+
+#include <map>
+
+#include "vm/kernel.h"
+#include "vm/kernel_binary.h"
+#include "vm/kernel_to_il.h"
+#include "vm/object.h"
+
+namespace dart {
+namespace kernel {
+
+class KernelFlowgraphBuilder {

[Kevin Millikin (Google), 2017/03/28 12:50:00]

I'd call this something like StreamingFlowGraphBuilder or
BinaryFlowGraphBuilder, because the other one is also a Kernel flow graph
builder so the generic name makes it confusing to talk about and it's easy to
change it later.

Plus, this is kernel::KerneFlowGraphBuilder which seems redundant.

Also be consistent.  We have (apparently) decided that "flow graph" is two words
so this should be capitalized like KernelFlowGraphBuilder.

[jensj, 2017/03/29 09:30:42]

Done.

+ public:
+  KernelFlowgraphBuilder(FlowGraphBuilder* flowGraph_builder,
+                         const uint8_t* buffer,
+                         intptr_t buffer_length)
+      : flowGraph_builder_(flowGraph_builder),
+        reader_(new kernel::Reader(buffer, buffer_length)) {}
+
+  virtual ~KernelFlowgraphBuilder() { delete reader_; }
+
+  Fragment BuildAt(int64_t kernel_offset);
+
+ private:
+  Fragment buildRethrow();

[Kevin Millikin (Google), 2017/03/28 12:50:00]

BuildRethrow()

[jensj, 2017/03/29 09:30:42]

Done.

+
+  FlowGraphBuilder* flowGraph_builder_;

[Kevin Millikin (Google), 2017/03/28 12:50:00]

flow_graph_builder_ or possibly flowgraph_builder_ if you change flowgraph to be
one word (I don't recommend it).   Definitely not flowGraph_builder_.

[jensj, 2017/03/29 09:30:42]

Done.

+  kernel::Reader* reader_;
+};
+
+}  // namespace kernel
+}  // namespace dart
+
+#endif  // !defined(DART_PRECOMPILED_RUNTIME)
+#endif  // RUNTIME_VM_KERNEL_BINARY_FLOWGRAPH_H_