Source/core/html/parser/TextDocumentParser.cpp - Issue 277633002: Convert DocumentParser code to Use more reference

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/html/parser/TextDocumentParser.cpp

Issue 277633002: Convert DocumentParser code to Use more reference (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Update rebased patch Created 6 years, 7 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/html/parser/TextDocumentParser.cpp

diff --git a/Source/core/html/parser/TextDocumentParser.cpp b/Source/core/html/parser/TextDocumentParser.cpp

index d29935a77c95559a13dbde1c3f6f887caa709d43..b64e271fca87c038da32873571a352497aa4d8b6 100644

--- a/Source/core/html/parser/TextDocumentParser.cpp

+++ b/Source/core/html/parser/TextDocumentParser.cpp

@@ -33,7 +33,7 @@ namespace WebCore {

using namespace HTMLNames;

TextDocumentParser::TextDocumentParser(HTMLDocument* document)

- : HTMLDocumentParser(document, false)

+ : HTMLDocumentParser(*document, false)

Inactive 2014/05/22 19:58:44 This looks unsafe unless TextDocumentParser() cons

maheshkk 2014/05/22 20:15:54 Made TextDocumentParser use reference too.

, m_haveInsertedFakePreElement(false)

{

}