Update ChromeDriver to accept W3C format InitSession

chrome/test/chromedriver/session_commands.cc

 // Copyright (c) 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/test/chromedriver/session_commands.h"
 
 #include <list>
 #include <utility>
 
 #include "base/bind.h"
@@ skipping 158 matching lines @@
   return Status(kOk);
 }
 
 Status InitSessionHelper(const InitSessionParams& bound_params,
                          Session* session,
                          const base::DictionaryValue& params,
                          std::unique_ptr<base::Value>* value) {
   session->driver_log.reset(
       new WebDriverLog(WebDriverLog::kDriverType, Log::kAll));
   const base::DictionaryValue* desired_caps;
-  bool w3c_capability = false;
-  if (params.GetDictionary("capabilities.desiredCapabilities", &desired_caps)
-      && desired_caps->GetBoolean("chromeOptions.w3c", &w3c_capability)
-      && w3c_capability)
+  const base::DictionaryValue default_desired_caps;

[samuong, 2017/03/28 21:30:00]

What is the difference between |desired_caps| and |default_desired_caps|?

+  if (params.GetDictionary("desiredCapabilities", &desired_caps) ||
+      params.GetDictionary("capabilities.desiredCapabilities", &desired_caps)) {

[samuong, 2017/03/28 21:30:00]

If we're going to continue supporting capabilties.desiredCapabilities, then we
should treat these clients as W3C-compliant, not as legacy clients.

+  } else if (params.GetDictionary("capabilities", nullptr)) {
     session->w3c_compliant = true;
-  else if (!params.GetDictionary("desiredCapabilities", &desired_caps) &&
-     !params.GetDictionary("capabilities.desiredCapabilities", &desired_caps))
-    return Status(kUnknownError, "cannot find dict 'desiredCapabilities'");
+    if (!params.GetDictionary("capabilities.alwaysMatch", &desired_caps))
+      desired_caps = &default_desired_caps;
+    // TBD: Handle capabilities.firstMatch.
+  } else {
+    return Status(kUnknownError,
+                  "cannot find dict 'capabilities' or 'desiredCapabilities'");

[samuong, 2017/03/28 21:30:00]

This error message needs to be updated

+  }
 
   Capabilities capabilities;
   Status status = capabilities.Parse(*desired_caps);
   if (status.IsError())
     return status;
 
   desired_caps->GetString("unexpectedAlertBehaviour",
                            &session->unexpected_alert_behaviour);
 
   Log::Level driver_level = Log::kWarning;
@@ skipping 691 matching lines @@
                                       std::unique_ptr<base::Value>* value) {
   WebView* web_view = nullptr;
   Status status = session->GetTargetWindow(&web_view);
   if (status.IsError())
     return status;
   status = web_view->DeleteScreenOrientation();
   if (status.IsError())
     return status;
   return Status(kOk);
 }