chrome/browser/resources/chromeos/chromevox/chromevox/background/options.js - Issue 2776293002: Refresh ChromeVox options page CSS

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/chromeos/chromevox/chromevox/background/options.js

Issue 2776293002: Refresh ChromeVox options page CSS (Closed)

Patch Set: Fix missing edits to chromevox_strings.grd Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/chromeos/chromevox/chromevox/background/options.html ('k') | chrome/browser/resources/chromeos/chromevox/chromevox/background/unchecked.png » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/chromeos/chromevox/chromevox/background/options.js

diff --git a/chrome/browser/resources/chromeos/chromevox/chromevox/background/options.js b/chrome/browser/resources/chromeos/chromevox/chromevox/background/options.js

index 53fc20aa6191e7f457f80449809fe4aa64b6068e..35d3ac6c38b213723a62fdfcd84ad56d80517f83 100644

--- a/chrome/browser/resources/chromeos/chromevox/chromevox/background/options.js

+++ b/chrome/browser/resources/chromeos/chromevox/chromevox/background/options.js

@@ -277,26 +277,18 @@ cvox.OptionsPage.populateBrailleTablesSelect = function() {

var updateTableType = function(setFocus) {

var currentTableType = localStorage['brailleTableType'] || 'brailleTable6';

if (currentTableType == 'brailleTable6') {

- select6.removeAttribute('aria-hidden');

- select6.setAttribute('tabIndex', 0);

- select6.style.display = 'block';

+ select6.parentElement.style.display = 'block';

+ select8.parentElement.style.display = 'none';

if (setFocus) {

select6.focus();

}

- select8.setAttribute('aria-hidden', 'true');

- select8.setAttribute('tabIndex', -1);

- select8.style.display = 'none';

localStorage['brailleTable'] = localStorage['brailleTable6'];

localStorage['brailleTableType'] = 'brailleTable6';

tableTypeButton.textContent =

Msgs.getMsg('options_braille_table_type_6');

} else {

- select6.setAttribute('aria-hidden', 'true');

- select6.setAttribute('tabIndex', -1);

- select6.style.display = 'none';

- select8.removeAttribute('aria-hidden');

- select8.setAttribute('tabIndex', 0);

- select8.style.display = 'block';

+ select6.parentElement.style.display = 'none';

+ select8.parentElement.style.display = 'block';

if (setFocus) {

select8.focus();

}