third_party/WebKit/Source/devtools/front_end/elements/ClassesPaneWidget.js - Issue 2776263006: [DevTools] Migrate checkbox label to a proper web component

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/devtools/front_end/elements/ClassesPaneWidget.js

Issue 2776263006: [DevTools] Migrate checkbox label to a proper web component (Closed)

Patch Set: Created 3 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/devtools/front_end/devices/DevicesView.js ('k') | third_party/WebKit/Source/devtools/front_end/elements/ElementStatePaneWidget.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/devtools/front_end/elements/ClassesPaneWidget.js

diff --git a/third_party/WebKit/Source/devtools/front_end/elements/ClassesPaneWidget.js b/third_party/WebKit/Source/devtools/front_end/elements/ClassesPaneWidget.js

index 619cf465b339bf3f1478fbd6cf0c44cc93289a14..726d94cd95d013e134eb238b562a2d02abb6abcf 100644

--- a/third_party/WebKit/Source/devtools/front_end/elements/ClassesPaneWidget.js

+++ b/third_party/WebKit/Source/devtools/front_end/elements/ClassesPaneWidget.js

@@ -100,7 +100,7 @@ Elements.ClassesPaneWidget = class extends UI.Widget {

keys.sort(String.caseInsensetiveComparator);

for (var i = 0; i < keys.length; ++i) {

var className = keys[i];

- var label = UI.createCheckboxLabel(className, classes.get(className));

+ var label = UI.CheckboxLabel.create(className, classes.get(className));

label.visualizeFocus = true;

label.classList.add('monospace');

label.checkboxElement.addEventListener('click', this._onClick.bind(this, className), false);