Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(320)

Side by Side Diff: third_party/WebKit/Source/devtools/front_end/sources/XHRBreakpointsSidebarPane.js

Issue 2776263006: [DevTools] Migrate checkbox label to a proper web component (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2015 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 /** 4 /**
5 * @implements {UI.ContextFlavorListener} 5 * @implements {UI.ContextFlavorListener}
6 * @implements {SDK.TargetManager.Observer} 6 * @implements {SDK.TargetManager.Observer}
7 * @implements {UI.ToolbarItem.ItemsProvider} 7 * @implements {UI.ToolbarItem.ItemsProvider}
8 * @unrestricted 8 * @unrestricted
9 */ 9 */
10 Sources.XHRBreakpointsSidebarPane = class extends Components.BreakpointsSidebarP aneBase { 10 Sources.XHRBreakpointsSidebarPane = class extends Components.BreakpointsSidebarP aneBase {
(...skipping 81 matching lines...) Expand 10 before | Expand all | Expand 10 after
92 if (this._breakpointElements.has(url)) { 92 if (this._breakpointElements.has(url)) {
93 this._breakpointElements.get(url)._checkboxElement.checked = enabled; 93 this._breakpointElements.get(url)._checkboxElement.checked = enabled;
94 return; 94 return;
95 } 95 }
96 96
97 var element = createElement('li'); 97 var element = createElement('li');
98 element._url = url; 98 element._url = url;
99 element.addEventListener('contextmenu', this._contextMenu.bind(this, url), t rue); 99 element.addEventListener('contextmenu', this._contextMenu.bind(this, url), t rue);
100 100
101 var title = url ? Common.UIString('URL contains "%s"', url) : Common.UIStrin g('Any XHR'); 101 var title = url ? Common.UIString('URL contains "%s"', url) : Common.UIStrin g('Any XHR');
102 var label = UI.createCheckboxLabel(title, enabled); 102 var label = UI.CheckboxLabel.create(title, enabled);
103 element.appendChild(label); 103 element.appendChild(label);
104 label.checkboxElement.addEventListener('click', this._checkboxClicked.bind(t his, url), false); 104 label.checkboxElement.addEventListener('click', this._checkboxClicked.bind(t his, url), false);
105 element._checkboxElement = label.checkboxElement; 105 element._checkboxElement = label.checkboxElement;
106 106
107 label.classList.add('cursor-auto'); 107 label.classList.add('cursor-auto');
108 label.textElement.addEventListener('dblclick', this._labelClicked.bind(this, url), false); 108 label.textElement.addEventListener('dblclick', this._labelClicked.bind(this, url), false);
109 109
110 var currentElement = /** @type {?Element} */ (this.listElement.firstChild); 110 var currentElement = /** @type {?Element} */ (this.listElement.firstChild);
111 while (currentElement) { 111 while (currentElement) {
112 if (currentElement._url && currentElement._url < element._url) 112 if (currentElement._url && currentElement._url < element._url)
(...skipping 132 matching lines...) Expand 10 before | Expand all | Expand 10 after
245 */ 245 */
246 _restoreBreakpoints(target) { 246 _restoreBreakpoints(target) {
247 var breakpoints = this._xhrBreakpointsSetting.get(); 247 var breakpoints = this._xhrBreakpointsSetting.get();
248 for (var i = 0; i < breakpoints.length; ++i) { 248 for (var i = 0; i < breakpoints.length; ++i) {
249 var breakpoint = breakpoints[i]; 249 var breakpoint = breakpoints[i];
250 if (breakpoint && typeof breakpoint.url === 'string') 250 if (breakpoint && typeof breakpoint.url === 'string')
251 this._setBreakpoint(breakpoint.url, breakpoint.enabled, target); 251 this._setBreakpoint(breakpoint.url, breakpoint.enabled, target);
252 } 252 }
253 } 253 }
254 }; 254 };
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698