Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4175)

Unified Diff: chrome/browser/extensions/requirements_checker_browsertest.cc

Issue 2776263004: expect the test finishes
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/extensions/requirements_checker_browsertest.cc
diff --git a/chrome/browser/extensions/requirements_checker_browsertest.cc b/chrome/browser/extensions/requirements_checker_browsertest.cc
index e7665ba37bc56e7b6da530e7d3814e89465309d2..7da5900de2fe7154039cc0557d8035191e6420be 100644
--- a/chrome/browser/extensions/requirements_checker_browsertest.cc
+++ b/chrome/browser/extensions/requirements_checker_browsertest.cc
@@ -47,6 +47,7 @@ class RequirementsCheckerBrowserTest : public ExtensionBrowserTest {
const std::vector<std::string>& expected_errors,
const std::vector<std::string>& actual_errors) {
ASSERT_EQ(expected_errors, actual_errors);
+ finished_ = true;
}
// This should only be called once per test instance. Calling more than once
@@ -77,6 +78,7 @@ class RequirementsCheckerBrowserTest : public ExtensionBrowserTest {
protected:
std::unique_ptr<RequirementsChecker> checker_;
+ bool finished_ = false;
};
IN_PROC_BROWSER_TEST_F(RequirementsCheckerBrowserTest, CheckEmptyExtension) {
@@ -87,6 +89,7 @@ IN_PROC_BROWSER_TEST_F(RequirementsCheckerBrowserTest, CheckEmptyExtension) {
&RequirementsCheckerBrowserTest::ValidateRequirementErrors,
base::Unretained(this), std::vector<std::string>()));
content::RunAllBlockingPoolTasksUntilIdle();
+ EXPECT_TRUE(finished_);
}
IN_PROC_BROWSER_TEST_F(RequirementsCheckerBrowserTest, CheckNpapiExtension) {
@@ -104,6 +107,7 @@ IN_PROC_BROWSER_TEST_F(RequirementsCheckerBrowserTest, CheckNpapiExtension) {
&RequirementsCheckerBrowserTest::ValidateRequirementErrors,
base::Unretained(this), expected_errors));
content::RunAllBlockingPoolTasksUntilIdle();
+ EXPECT_TRUE(finished_);
}
IN_PROC_BROWSER_TEST_F(RequirementsCheckerBrowserTest,
@@ -122,6 +126,7 @@ IN_PROC_BROWSER_TEST_F(RequirementsCheckerBrowserTest,
&RequirementsCheckerBrowserTest::ValidateRequirementErrors,
base::Unretained(this), expected_errors));
content::RunAllBlockingPoolTasksUntilIdle();
+ EXPECT_TRUE(finished_);
}
IN_PROC_BROWSER_TEST_F(RequirementsCheckerBrowserTest, DisallowWebGL) {
@@ -143,6 +148,7 @@ IN_PROC_BROWSER_TEST_F(RequirementsCheckerBrowserTest, DisallowWebGL) {
&RequirementsCheckerBrowserTest::ValidateRequirementErrors,
base::Unretained(this), expected_errors));
content::RunAllBlockingPoolTasksUntilIdle();
+ EXPECT_TRUE(finished_);
}
IN_PROC_BROWSER_TEST_F(RequirementsCheckerBrowserTest, Check3DExtension) {
@@ -161,6 +167,7 @@ IN_PROC_BROWSER_TEST_F(RequirementsCheckerBrowserTest, Check3DExtension) {
&RequirementsCheckerBrowserTest::ValidateRequirementErrors,
base::Unretained(this), expected_errors));
content::RunAllBlockingPoolTasksUntilIdle();
+ EXPECT_TRUE(finished_);
}
} // namespace extensions
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698