Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(700)

Side by Side Diff: content/browser/databases_table_unittest.cc

Issue 2776253002: Move some database tests next to the files they cover. (Closed)
Patch Set: Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « content/browser/database_util_unittest.cc ('k') | content/test/BUILD.gn » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
(Empty)
1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file.
4
5 #include <stddef.h>
6
7 #include "base/bind.h"
8 #include "base/strings/string_util.h"
9 #include "base/strings/utf_string_conversions.h"
10 #include "sql/connection.h"
11 #include "sql/statement.h"
12 #include "sql/test/scoped_error_expecter.h"
13 #include "storage/browser/database/databases_table.h"
14 #include "testing/gtest/include/gtest/gtest.h"
15 #include "third_party/sqlite/sqlite3.h"
16
17 using base::ASCIIToUTF16;
18 using storage::DatabaseDetails;
19 using storage::DatabasesTable;
20
21 namespace content {
22
23 static void CheckDetailsAreEqual(const DatabaseDetails& d1,
24 const DatabaseDetails& d2) {
25 EXPECT_EQ(d1.origin_identifier, d2.origin_identifier);
26 EXPECT_EQ(d1.database_name, d2.database_name);
27 EXPECT_EQ(d1.description, d2.description);
28 EXPECT_EQ(d1.estimated_size, d2.estimated_size);
29 }
30
31 static bool DatabasesTableIsEmpty(sql::Connection* db) {
32 sql::Statement statement(db->GetCachedStatement(
33 SQL_FROM_HERE, "SELECT COUNT(*) FROM Databases"));
34 return (statement.is_valid() && statement.Step() && !statement.ColumnInt(0));
35 }
36
37 TEST(DatabasesTableTest, TestIt) {
38 // Initialize the 'Databases' table.
39 sql::Connection db;
40
41 sql::test::ScopedErrorExpecter expecter;
42 // TODO(shess): Suppressing SQLITE_CONSTRAINT because the code
43 // expects that and handles the resulting error. Consider revising
44 // the code to use INSERT OR IGNORE (which would not throw
45 // SQLITE_CONSTRAINT) and then check ChangeCount() to see if any
46 // changes were made.
47 expecter.ExpectError(SQLITE_CONSTRAINT);
48
49 // Initialize the temp dir and the 'Databases' table.
50 EXPECT_TRUE(db.OpenInMemory());
51 DatabasesTable databases_table(&db);
52 EXPECT_TRUE(databases_table.Init());
53
54 // The 'Databases' table should be empty.
55 EXPECT_TRUE(DatabasesTableIsEmpty(&db));
56
57 // Create the details for a databases.
58 DatabaseDetails details_in1;
59 DatabaseDetails details_out1;
60 details_in1.origin_identifier = "origin1";
61 details_in1.database_name = ASCIIToUTF16("db1");
62 details_in1.description = ASCIIToUTF16("description_db1");
63 details_in1.estimated_size = 100;
64
65 // Updating details for this database should fail.
66 EXPECT_FALSE(databases_table.UpdateDatabaseDetails(details_in1));
67 EXPECT_FALSE(databases_table.GetDatabaseDetails(
68 details_in1.origin_identifier,
69 details_in1.database_name,
70 &details_out1));
71
72 // Inserting details for this database should pass.
73 EXPECT_TRUE(databases_table.InsertDatabaseDetails(details_in1));
74 EXPECT_TRUE(databases_table.GetDatabaseDetails(
75 details_in1.origin_identifier,
76 details_in1.database_name,
77 &details_out1));
78 EXPECT_EQ(1, databases_table.GetDatabaseID(details_in1.origin_identifier,
79 details_in1.database_name));
80
81 // Check that the details were correctly written to the database.
82 CheckDetailsAreEqual(details_in1, details_out1);
83
84 // Check that inserting a duplicate row fails.
85 EXPECT_FALSE(databases_table.InsertDatabaseDetails(details_in1));
86
87 // Insert details for another database with the same origin.
88 DatabaseDetails details_in2;
89 details_in2.origin_identifier = "origin1";
90 details_in2.database_name = ASCIIToUTF16("db2");
91 details_in2.description = ASCIIToUTF16("description_db2");
92 details_in2.estimated_size = 200;
93 EXPECT_TRUE(databases_table.InsertDatabaseDetails(details_in2));
94 EXPECT_EQ(2, databases_table.GetDatabaseID(details_in2.origin_identifier,
95 details_in2.database_name));
96
97 // Insert details for a third database with a different origin.
98 DatabaseDetails details_in3;
99 details_in3.origin_identifier = "origin2";
100 details_in3.database_name = ASCIIToUTF16("db3");
101 details_in3.description = ASCIIToUTF16("description_db3");
102 details_in3.estimated_size = 300;
103 EXPECT_TRUE(databases_table.InsertDatabaseDetails(details_in3));
104 EXPECT_EQ(3, databases_table.GetDatabaseID(details_in3.origin_identifier,
105 details_in3.database_name));
106
107 // There should be no database with origin "origin3".
108 std::vector<DatabaseDetails> details_out_origin3;
109 EXPECT_TRUE(databases_table.GetAllDatabaseDetailsForOriginIdentifier(
110 "origin3", &details_out_origin3));
111 EXPECT_TRUE(details_out_origin3.empty());
112
113 // There should be only two databases with origin "origin1".
114 std::vector<DatabaseDetails> details_out_origin1;
115 EXPECT_TRUE(databases_table.GetAllDatabaseDetailsForOriginIdentifier(
116 details_in1.origin_identifier, &details_out_origin1));
117 EXPECT_EQ(size_t(2), details_out_origin1.size());
118 CheckDetailsAreEqual(details_in1, details_out_origin1[0]);
119 CheckDetailsAreEqual(details_in2, details_out_origin1[1]);
120
121 // Get the list of all origins: should be "origin1" and "origin2".
122 std::vector<std::string> origins_out;
123 EXPECT_TRUE(databases_table.GetAllOriginIdentifiers(&origins_out));
124 EXPECT_EQ(size_t(2), origins_out.size());
125 EXPECT_EQ(details_in1.origin_identifier, origins_out[0]);
126 EXPECT_EQ(details_in3.origin_identifier, origins_out[1]);
127
128 // Delete an origin and check that it's no longer in the table.
129 origins_out.clear();
130 EXPECT_TRUE(databases_table.DeleteOriginIdentifier(
131 details_in3.origin_identifier));
132 EXPECT_TRUE(databases_table.GetAllOriginIdentifiers(&origins_out));
133 EXPECT_EQ(size_t(1), origins_out.size());
134 EXPECT_EQ(details_in1.origin_identifier, origins_out[0]);
135
136 // Deleting an origin that doesn't have any record in this table should fail.
137 EXPECT_FALSE(databases_table.DeleteOriginIdentifier("unknown_origin"));
138
139 // Delete the details for 'db1' and check that they're no longer there.
140 EXPECT_TRUE(databases_table.DeleteDatabaseDetails(
141 details_in1.origin_identifier, details_in1.database_name));
142 EXPECT_FALSE(databases_table.GetDatabaseDetails(
143 details_in1.origin_identifier,
144 details_in1.database_name,
145 &details_out1));
146
147 // Check that trying to delete a record that doesn't exist fails.
148 EXPECT_FALSE(databases_table.DeleteDatabaseDetails(
149 "unknown_origin", ASCIIToUTF16("unknown_database")));
150
151 ASSERT_TRUE(expecter.SawExpectedErrors());
152 }
153
154 } // namespace content
OLDNEW
« no previous file with comments | « content/browser/database_util_unittest.cc ('k') | content/test/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698