Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(597)

Unified Diff: chrome/android/java/AndroidManifest.xml

Issue 2776243007: Enable WebVR presentation from Chrome Custom Tab (Closed)
Patch Set: Remove file IO, fix PendingIntent errors Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/AndroidManifest.xml
diff --git a/chrome/android/java/AndroidManifest.xml b/chrome/android/java/AndroidManifest.xml
index b6d789cb7c0873406ed5f6eed1cdf1c654e0123a..e81df4b51aeae4de32c7495e4418233b296b1cfd 100644
--- a/chrome/android/java/AndroidManifest.xml
+++ b/chrome/android/java/AndroidManifest.xml
@@ -50,6 +50,7 @@ by a child template that "extends" this file.
<uses-permission android:name="android.permission.READ_SYNC_STATS"/>
<uses-permission android:name="android.permission.RECEIVE_BOOT_COMPLETED"/>
<uses-permission android:name="android.permission.RECORD_AUDIO"/>
+ <uses-permission android:name="android.permission.REORDER_TASKS"/>
<uses-permission android:name="android.permission.USE_CREDENTIALS"/>
<uses-permission android:name="android.permission.VIBRATE"/>
<uses-permission android:name="android.permission.WAKE_LOCK"/>
@@ -73,10 +74,14 @@ by a child template that "extends" this file.
android:label="Debug web pages"
android:permissionGroup="android.permission-group.DEVELOPMENT_TOOLS"
android:protectionLevel="signature" />
+ <!-- Only chrome can receive the vr entry result -->
+ <permission android:name="{{ manifest_package }}.permission.VR_ENTRY"
+ android:protectionLevel="signature" />
<uses-permission android:name="{{ manifest_package }}.permission.C2D_MESSAGE" />
<uses-permission android:name="{{ manifest_package }}.permission.READ_WRITE_BOOKMARK_FOLDERS" />
<uses-permission android:name="{{ manifest_package }}.TOS_ACKED" />
+ <uses-permission android:name="{{ manifest_package }}.permission.VR_ENTRY" />
mthiesse 2017/04/06 21:50:40 Note that this also requires a change to third_par
<uses-permission android:name="com.chrome.permission.DEVICE_EXTRAS" />
<uses-permission android:name="com.android.browser.permission.READ_HISTORY_BOOKMARKS"/>
@@ -365,41 +370,7 @@ by a child template that "extends" this file.
{% block supports_video_persistence %}
{% endblock %}
>
- <!--
- See the VRChromeTabbedActivity alias below for an explanation of this dummy intent
- filter. We need to add these filters here as well, or non-presenting webVR pages will
- trigger a daydream incompatible app message.
- -->
- <intent-filter>
- <action android:name="org.chromium.chrome.browser.dummy.action" />
- <category android:name="com.google.intent.category.DAYDREAM" />
- <category android:name="com.google.intent.category.CARDBOARD" />
- </intent-filter>
</activity>
-
- {% if enable_vr == "true" %}
- <!--
- TODO(mthiesse): Temporarily skip ChromeLauncherActivity when returning from Daydream
- DON flow to avoid polluting metrics.
- -->
- <activity-alias android:name="org.chromium.chrome.browser.VRChromeTabbedActivity"
- android:targetActivity="org.chromium.chrome.browser.ChromeTabbedActivity"
- android:enableVrMode="@string/gvr_vr_mode_component">
- <!--
- Daydream api categorizes an activity to three categories: Cardboard only, hybrid
- or Daydream. It does so by testing if intents can be resolved by the activity
- that requests it.
- In Chrome, CTA is the activity that uses Daydream api and we want to be in hybrid
- category. So add an intent filter that could pass Daydream tests here.
- -->
- <intent-filter>
- <action android:name="org.chromium.chrome.browser.dummy.action" />
- <category android:name="com.google.intent.category.DAYDREAM" />
- <category android:name="com.google.intent.category.CARDBOARD" />
- </intent-filter>
- </activity-alias>
- {% endif %}
-
<activity android:name="org.chromium.chrome.browser.ChromeTabbedActivity2"
android:theme="@style/TabbedModeTheme"
android:exported="false"
@@ -630,6 +601,27 @@ by a child template that "extends" this file.
android:excludeFromRecents="true">
</activity>
+ {% if enable_vr == "true" %}
+ <!-- Activity for dispatching intents to VR-enabled ChromeActivitys. This is necessary
+ because we can't return to CCT via a pendingIntent, which is how Daydream normally
+ launches an app after the DON flow. -->
+ <activity android:name="org.chromium.chrome.browser.vr_shell.VrProxyActivity"
+ android:exported="false"
+ android:theme="@android:style/Theme.NoDisplay"
+ android:noHistory="true"
+ android:excludeFromRecents="true"
+ android:relinquishTaskIdentity="true"
+ android:taskAffinity=""
+ android:configChanges="orientation|keyboardHidden|keyboard|screenSize|mcc|mnc|screenLayout|smallestScreenSize|uiMode" >
+ android:launchMode="singleInstance">
+ <intent-filter>
+ <action android:name="org.chromium.chrome.browser.dummy.action" />
+ <category android:name="com.google.intent.category.DAYDREAM" />
+ <category android:name="com.google.intent.category.CARDBOARD" />
+ </intent-filter>
+ </activity>
+ {% endif %}
+
<!-- Service for handling Nearby Messages -->
<service android:name="org.chromium.chrome.browser.physicalweb.NearbyMessageIntentService"
android:exported="false" />
« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698