chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellImpl.java - Issue 2776243007: Enable WebVR presentation from Chrome Custom Tab

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellImpl.java

Issue 2776243007: Enable WebVR presentation from Chrome Custom Tab (Closed)

Patch Set: rebase + address nit Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellDelegate.java ('k') | chrome/android/javatests/src/org/chromium/chrome/browser/vr_shell/VrShellTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellImpl.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellImpl.java b/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellImpl.java

index f5650c3fa0708c6e394b82629aff82cff3eff9d2..d4436e1e234418e1713207c29dc3974475652321 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellImpl.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/vr_shell/VrShellImpl.java

@@ -156,7 +156,7 @@ public class VrShellImpl

getUiLayout().setCloseButtonListener(new Runnable() {

@Override

public void run() {

- mDelegate.shutdownVR(false /* isPausing */, false /* showTransition */);

+ mDelegate.shutdownVr(false /* isPausing */, false /* showTransition */);

}

});

@@ -355,7 +355,7 @@ public class VrShellImpl

private void swapToForegroundTab() {

Tab tab = mActivity.getActivityTab();

if (tab == mTab) return;

- if (!mDelegate.canEnterVR(tab)) {

+ if (!mDelegate.canEnterVr(tab)) {

forceExitVr();

return;

}

@@ -391,7 +391,7 @@ public class VrShellImpl

// Exits VR, telling the user to remove their headset, and returning to Chromium.

@CalledByNative

public void forceExitVr() {

- mDelegate.shutdownVR(false /* isPausing */, true /* showTransition */);

+ mDelegate.shutdownVr(false /* isPausing */, true /* showTransition */);

}

@CalledByNative