Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Issue 2776233002: Enhance the change builders (Closed)

Created:
3 years, 9 months ago by Brian Wilkerson
Modified:
3 years, 8 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+779 lines, -78 lines) Patch
M pkg/analysis_server/lib/src/provisional/edit/utilities/change_builder_core.dart View 1 chunk +22 lines, -0 lines 0 comments Download
M pkg/analysis_server/lib/src/provisional/edit/utilities/change_builder_dart.dart View 7 chunks +102 lines, -8 lines 0 comments Download
M pkg/analysis_server/lib/src/utilities/change_builder_core.dart View 1 chunk +20 lines, -0 lines 0 comments Download
M pkg/analysis_server/lib/src/utilities/change_builder_dart.dart View 11 chunks +236 lines, -51 lines 0 comments Download
M pkg/analysis_server/test/src/utilities/change_builder_dart_test.dart View 11 chunks +399 lines, -19 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Brian Wilkerson
Adds some additional functionality that will be useful when converting over to use them.
3 years, 9 months ago (2017-03-27 18:03:21 UTC) #2
scheglov
LGTM
3 years, 9 months ago (2017-03-27 18:31:53 UTC) #3
Brian Wilkerson
3 years, 8 months ago (2017-03-28 15:29:36 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
84f2f4a677cba90f3af38ae080ef60c9228c9dc9 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698