Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1626)

Unified Diff: components/autofill/core/browser/form_structure.h

Issue 2776223002: Adds UKM for autofill attributes in form_structure. (Closed)
Patch Set: Uses vector of pairs instead of map for metrics. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/autofill/core/browser/form_structure.h
diff --git a/components/autofill/core/browser/form_structure.h b/components/autofill/core/browser/form_structure.h
index e984a5f1514a86057e894c0ef519bb716d186439..9ec5d70b8bc6970771a808fb69fc527b1e344e78 100644
--- a/components/autofill/core/browser/form_structure.h
+++ b/components/autofill/core/browser/form_structure.h
@@ -37,6 +37,10 @@ namespace rappor {
class RapporServiceImpl;
}
+namespace ukm {
+class UkmService;
+}
+
namespace autofill {
struct FormData;
@@ -50,8 +54,9 @@ class FormStructure {
virtual ~FormStructure();
// Runs several heuristics against the form fields to determine their possible
- // types.
- void DetermineHeuristicTypes();
+ // types. If |ukm_service| is specified, logs UKM for the form structure
+ // corresponding to |source_url_|.
+ void DetermineHeuristicTypes(ukm::UkmService* ukm_service);
// Encodes the proto |upload| request from this FormStructure.
// In some cases, a |login_form_signature| is included as part of the upload.

Powered by Google App Engine
This is Rietveld 408576698