Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Unified Diff: components/autofill/core/browser/autofill_metrics.h

Issue 2776223002: Adds UKM for autofill attributes in form_structure. (Closed)
Patch Set: Uses vector of pairs instead of map for metrics. Created 3 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/autofill/core/browser/autofill_metrics.h
diff --git a/components/autofill/core/browser/autofill_metrics.h b/components/autofill/core/browser/autofill_metrics.h
index d0aba8221f6a042da66e97546fa6324a761df639..a2cb6e6a1ec4ef328142f75d7b388962aeaf552a 100644
--- a/components/autofill/core/browser/autofill_metrics.h
+++ b/components/autofill/core/browser/autofill_metrics.h
@@ -7,6 +7,8 @@
#include <stddef.h>
#include <string>
+#include <utility>
+#include <vector>
#include "base/macros.h"
#include "components/autofill/core/browser/autofill_client.h"
@@ -27,6 +29,8 @@ namespace internal {
// Name constants are exposed here so they can be referenced from tests.
extern const char kUKMCardUploadDecisionEntryName[];
extern const char kUKMCardUploadDecisionMetricName[];
+extern const char kUKMDeveloperEngagementEntryName[];
+extern const char kUKMDeveloperEngagementMetricName[];
} // namespace internal
namespace autofill {
@@ -697,12 +701,19 @@ class AutofillMetrics {
const GURL& url,
AutofillMetrics::CardUploadDecisionMetric upload_decision);
+ // Logs the developer engagement ukm for the specified |url| and autofill
+ // fields in the form structure.
+ static void LogDeveloperEngagementUkm(
+ ukm::UkmService* ukm_service,
+ const GURL& url,
+ const std::vector<AutofillMetrics::DeveloperEngagementMetric>& metrics);
+
// Logs the the |ukm_entry_name| with the specified |url| and the specified
// |metrics|. Returns whether the ukm was sucessfully logged.
static bool LogUkm(ukm::UkmService* ukm_service,
const GURL& url,
const std::string& ukm_entry_name,
- const std::map<std::string, int>& metrics);
+ const std::vector<std::pair<const char*, int>>& metrics);
// Utility to autofill form events in the relevant histograms depending on
// the presence of server and/or local data.

Powered by Google App Engine
This is Rietveld 408576698